Repository navigation
feat: hoist definitions of JSON Schemas returned by cast resolvers - #50
Merged
schmurfy merged 2 commits intoOct 6, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cast resolver (
chipi:"as:...") may return a standalone JSON Schema declaring its owndefinitions/$defsand referencing them locally (#/definitions/x). Once embedded in the OpenAPI document those refs resolve against the document root and are broken.chipi now moves these definitions to
components/schemasascustom_<castName>.<name>and rewrites the local refs, including refs between definitions. The resolver schema is copied first, so a resolver returning a shared schema is left untouched and every generation hoists again.Note:
TestSchema"should use oneof as refs for enums and cast fields with as:" already fails onmaster, unrelated to this change.🤖 Generated with Claude Code