Enable event navigation in pop_editeventvals dialog#230
Open
claude[bot] wants to merge 1 commit into
Open
Conversation
The dialog wired the <<, <, >, >> nav buttons as enabled=False and provided no callback, so users could only browse event 1 even with many events in EEG.event. Enable the four buttons when len(events) > 1, ship each one with a navigate_event CallbackSpec carrying its delta plus the per-event display values, and handle the callback in the Qt renderer to clamp the eventnum into [1, N] and refresh the field_* widgets. Fixes #228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pop_editeventvals dialog hardcoded the four event navigation buttons (<<, <, >, >>) as disabled with no callback, so the eventnum field stayed at 1 and only the first event was browsable. Enable the buttons when the dataset has multiple events and add a navigate_event callback in the Qt renderer that clamps eventnum into [1, N] and refreshes the field_* widgets from the per-event display values cached in the spec.
Fixes #228