Skip to content

Build multi-destination replicationInfo per backend#6172

Open
maeldonn wants to merge 3 commits into
development/9.4from
improvement/CLDSRV-888/crr-multi
Open

Build multi-destination replicationInfo per backend#6172
maeldonn wants to merge 3 commits into
development/9.4from
improvement/CLDSRV-888/crr-multi

Conversation

@maeldonn
Copy link
Copy Markdown
Contributor

Issue: CLDSRV-888

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 18, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3378 5 3373 0
View the full list of 5 ❄️ flaky test(s)
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.014s run time
We encountered an internal error. Please try again.
"before each" hook for "should retrieve a part put after part copied from MPU"::GET object With default signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part put after part copied from MPU"

Flake rate in main: 100.00% (Passed 0 times, Failed 9 times)

Stack Traces | 6.28s run time
Connection timed out after 5000 ms
should not accept configuration when 'Destination' properties of two or more rules specify different buckets::aws-node-sdk test putBucketReplication configuration rules should not accept configuration when 'Destination' properties of two or more rules specify different buckets

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.003s run time
incorrect error response code: should be 'InvalidRequest' but got 'Error'
+ actual - expected

+ 'Error'
- 'InvalidRequest'
should not accept configuration when rules contain overlapping 'Prefix' values: new prefix starts with used prefix::aws-node-sdk test putBucketReplication configuration rules should not accept configuration when rules contain overlapping 'Prefix' values: new prefix starts with used prefix

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.004s run time
incorrect error response code: should be 'InvalidRequest' but got 'Error'
+ actual - expected

+ 'Error'
- 'InvalidRequest'
should not accept configuration when rules contain overlapping 'Prefix' values: used prefix starts with new prefix::aws-node-sdk test putBucketReplication configuration rules should not accept configuration when rules contain overlapping 'Prefix' values: used prefix starts with new prefix

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 0.003s run time
incorrect error response code: should be 'InvalidRequest' but got 'Error'
+ actual - expected

+ 'Error'
- 'InvalidRequest'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scality scality deleted a comment from bert-e May 20, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@maeldonn maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from 545c4b6 to 0ff3941 Compare May 27, 2026 07:47
Comment thread lib/api/apiUtils/object/getReplicationInfo.js Outdated
@claude
Copy link
Copy Markdown

claude Bot commented May 27, 2026

  • ReplicationConfiguration.resolveDestinationRole (line 166 of getReplicationInfo.js) does not exist in Arsenal — not in the pinned 8.4.2 tag, not on any branch, and not in any open PR across the scality org. This will crash at runtime for CRR backends and the unit tests referencing CRR destinations will also fail.
    - Add a companion Arsenal PR with this method and bump the arsenal dependency, or implement the role-resolution logic inline.

    Review by Claude Code

@maeldonn maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from 0ff3941 to b98f98f Compare May 28, 2026 15:17
Comment thread lib/api/apiUtils/object/getReplicationInfo.js
@claude
Copy link
Copy Markdown

claude Bot commented May 28, 2026

  • Arsenal dependency not bumped: ReplicationConfiguration.resolveBackends and resolveSourceRole do not exist in arsenal 8.4.2. All 110 unit test failures are TypeError: ReplicationConfiguration.resolveBackends is not a function. Bump the arsenal dependency in package.json to a version that exports these static methods.
    - Prettier check failing on all 4 changed files. Run prettier --write on them.

    The refactoring logic itself (service-account gate extraction, default-storageClass helper, per-backend CRR/cloud handling in ACL flow) looks correct and well-tested, pending the arsenal dependency.

    Review by Claude Code

@maeldonn maeldonn requested review from a team, benzekrimaha and delthas May 29, 2026 08:58
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 29, 2026

Conflict

There is a conflict between your branch improvement/CLDSRV-888/crr-multi and the
destination branch development/9.4.

Please resolve the conflict on the feature branch (improvement/CLDSRV-888/crr-multi).

git fetch && \
git checkout origin/improvement/CLDSRV-888/crr-multi && \
git merge origin/development/9.4

Resolve merge conflicts and commit

git push origin HEAD:improvement/CLDSRV-888/crr-multi

@maeldonn maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch 4 times, most recently from e9693df to f98710c Compare June 5, 2026 15:56
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 5, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Comment thread package.json Outdated
"@opentelemetry/instrumentation-mongodb": "~0.69.0",
"@smithy/node-http-handler": "^3.0.0",
"arsenal": "git+https://github.com/scality/Arsenal#8.4.5",
"arsenal": "git+https://github.com/scality/Arsenal#e4860ebc364db6c3cd5b3f3210339d0fa512ed24",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arsenal is pinned to a commit hash instead of a tag. The resolved version (8.4.3) is also a downgrade from the previous 8.4.5. Per project conventions, git-based deps must pin to a tag. Update this to a proper tag once the arsenal changes are released.

— Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented Jun 5, 2026

  • Arsenal is pinned to a commit hash (e4860ebc) instead of a tag, and the resolved version (8.4.3) is a downgrade from the previous 8.4.5. Pin to a proper tag once the arsenal changes are released.

Review by Claude Code

maeldonn added 2 commits June 5, 2026 18:13
Match all enabled rules with the object's prefix (highest-priority wins
on site collision) and stamp destination/role per CRR backend. Cloud
backends get a bare entry — their bucket and credentials live in the
location config. ACL replication uses per-backend `role` as the CRR
marker so cloud backends keep their status. Legacy V1 and
comma-separated `StorageClass` remain supported on read.

Issue: CLDSRV-888
@maeldonn maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from f98710c to a8a04b6 Compare June 5, 2026 16:17
Comment thread package.json Outdated
@claude
Copy link
Copy Markdown

claude Bot commented Jun 5, 2026

  • Arsenal dependency is pinned to a raw commit hash instead of a tag, and yarn.lock shows a version downgrade from 8.4.5 to 8.4.3. Pin to a tagged release.

    Review by Claude Code

@maeldonn maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from a8a04b6 to e413e0b Compare June 5, 2026 16:35
Comment thread package.json
@claude
Copy link
Copy Markdown

claude Bot commented Jun 5, 2026

  • Arsenal dependency is pinned to a raw commit hash instead of a release tag. Git-based deps should pin to a tag for reproducibility and clarity.

    Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants