Repository navigation
[2.x] perf: Don't re-convert the classpath in withBootclasspath - #1834
Open
hoangmaihuy wants to merge 1 commit into
Open
hoangmaihuy wants to merge 1 commit into
hoangmaihuy wants to merge 1 commit into
Conversation
withBootclasspath turned the VirtualFile classpath it was given back into paths and converted each one again. With sbt 2's MappedFileConverter every class directory on the classpath is listed again on every compile. Reuse the entries that were passed in and convert only the paths finishClasspath adds. Generated-by: Claude Opus 5.5 (Claude Code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dtk5cyfJFa66ZRoKprmT6
Contributor
Author
|
Benchmark smoke test failed due to connection reset when fetching artifacts, not related to this PR changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Developed with Claude Code with human review in the loop
Fixes #1833
Change
Reuse the entries that were passed in, and convert only the paths
finishClasspathaddsVerification
sbt built against this zinc: sbt
develop(0a70458a4) built against 2.1.0-M5 (before) and against this branch (after), on sbt-compile-benchmark'sscale-big(81 modules in three chains of 27, ~640 class files each), macOS. Medians of 8 interleaved rounds; sbt 1.13.0 ran the same rounds alone afterwards, for reference:m1appIn a wall-clock profile of the chain-root edit, work under
withBootclasspathfalls from 4.1 thread-seconds per edit to 0, and total work from 8.7 to 4.8.