Repository navigation
Run all unit tests on CI - #1830
Merged
Merged
Conversation
Contributor
Author
|
CI failing on first commit shows that |
Contributor
Author
|
Added a commit to set the |
This comment was marked as outdated.
This comment was marked as outdated.
eed3si9n
reviewed
Sep 24, 2026
In sbt 2, test only runs tests whose inputs changed since they last passed, and CI restores sbt's cache. The inputs are the test's classpath dependencies, so tests that load code by path never rerun: after deliberately breaking the compiler bridge and publishing it, test reported "No tests to run" for the bridge tests, while testFull failed. CI now uses testFull. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The test passes :q as the REPL's initial command, but the console bridge compiles initial commands as code, so the REPL waits for input and hangs until CI times out. It didn't show before because sbt 2 skipped the test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The bridge tests load the compiler bridges by path and read the bridge version from javaOptions, so sbt's incremental test didn't count either as an input and kept skipping them after a change. Both are now part of the tests' cache key. CI runs testFull anyway; this makes test reliable locally. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
PRs listed the jobs by their matrix values, such as "test (ubuntu-latest, 17, zulu, 1)", which doesn't say what a job does. The distribution was also wrong: it wasn't used, and every job runs on Temurin. The jobs are now named, e.g. "Test (Windows, JDK 17)". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sbt 2, test only runs tests whose inputs changed since they last passed, and CI restores sbt's cache. The inputs are the test's classpath dependencies, so tests that load code by path never rerun: after deliberately breaking the compiler bridge and publishing it, test reported "No tests to run" for the bridge tests, while testFull failed. CI now uses testFull.