refactor: improve clear() method in DomRenderer to handle text node unwrapping - #36
Conversation
saurabhiam
commented
Mar 17, 2026
saurabhiam
commented
- Updated the clear() method to unwrap text nodes from wrapper elements more efficiently.
- Ensured that text nodes are preserved and correctly reinserted into the DOM structure.
- Enhanced handling of wrapper elements to maintain DOM integrity during the clear operation.
…nwrapping - Updated the clear() method to unwrap text nodes from wrapper elements more efficiently. - Ensured that text nodes are preserved and correctly reinserted into the DOM structure. - Enhanced handling of wrapper elements to maintain DOM integrity during the clear operation.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📦 Bundle Size Report
✅ All packages within size limits |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The DomRenderer.clear() method was refactored to specifically unwrap single text nodes from wrapper elements, assuming wrapTextRange always creates a text node. The reviewer suggests an improvement to remove an unnecessary null check for wrapper.firstChild and use a non-null assertion, as wrapTextRange guarantees the presence of a first child, simplifying the code.
…derer - Updated the DomRenderer to use a non-null assertion for matchTextNode, ensuring it is always defined when unwrapping text nodes from wrapper elements. - This change improves the reliability of the text node handling during the clear operation.
- Removed the hyperlink from the footer in Layout.vue, simplifying the text to "Made with ♥ in India". - Added new parameters `iframes` and `iframesTimeout` to the core API documentation, detailing their functionality. - Clarified the DOM renderer description in the getting started guide to specify behavior when matches occur at the start of text nodes. - Updated README.md for Angular to reflect the new behavior of the DOM renderer regarding text node handling.
1 participant
