Skip to content

Allow unique artifacts for module test variants - #387

Merged
sauce-base merged 1 commit into
mainfrom
ci/reusable-workflow-artifact-suffix
Sep 25, 2026
Merged

sauce-base merged 1 commit into
mainfrom
ci/reusable-workflow-artifact-suffix

Conversation

@roble

@roble roble commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Adds an optional artifact suffix to the reusable module-test workflow and applies it consistently to environment and Playwright artifacts. This lets callers run multiple variants of the same module and framework in one workflow without artifact-name collisions.

Summary by CodeRabbit

  • Chores
    • Test runs can now add an optional suffix to generated environment and Playwright report artifacts, making artifact names configurable. When no suffix is provided, artifact naming remains unchanged.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a73ddbb0-e926-4130-a9cb-af191c7dce2d

📥 Commits

Reviewing files that changed from the base of the PR and between 6c30989 and 158cb0b.

📒 Files selected for processing (1)
  • .github/workflows/test-module.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test-module workflow adds an optional artifact_suffix input, defaulting to an empty string. It appends the value to the Saucebase environment artifact name for upload and download, and to the Playwright report artifact name.

Changes

Workflow artifact naming

Layer / File(s) Summary
Configure artifact suffix
.github/workflows/test-module.yml
The workflow defines an optional artifact_suffix input and appends it to the Saucebase environment upload and download artifact names and the Playwright report artifact name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 158cb

The artifact naming change is mergeable after normal checks; no conflicting report consumer or remaining issue was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 158cb

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/test-module.yml: Adds the optional artifact_suffix workflow input as a string defaulting to an empty value.
  • observed — Modified behavior in .github/workflows/test-module.yml: The Saucebase environment artifact upload name now appends inputs.artifact_suffix.
  • observed — Modified behavior in .github/workflows/test-module.yml: The environment artifact download name now appends the same suffix used by the upload step.
  • observed — Modified behavior in .github/workflows/test-module.yml: The Playwright report artifact name now appends inputs.artifact_suffix.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding unique artifact names for module test variants.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@sauce-base
sauce-base merged commit e49c558 into main Sep 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants