Skip to content

Allow module tests to select the Saucebase ref - #386

Merged
sauce-base merged 1 commit into
mainfrom
ci/module-saucebase-ref
Sep 25, 2026
Merged

sauce-base merged 1 commit into
mainfrom
ci/module-saucebase-ref

Conversation

@roble

@roble roble commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add an optional saucebase_ref input to the reusable module test workflow
  • default to main so existing callers remain unchanged
  • use the selected branch, tag, or commit when checking out Saucebase

Testing

  • act resolved saucebase_ref: dev-v3, installed auth, billing, and tenancy, and applied all standard and optional patches
  • the later Laravel setup step hit the known local act container issue where node is unavailable

Summary by CodeRabbit

  • New Features
    • Module tests can now target a selected Saucebase branch, tag, or commit. By default, tests use the main branch.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 25df80e6-b9da-482d-b97b-1bf810374d51

📥 Commits

Reviewing files that changed from the base of the PR and between d8274b2 and c6b6acf.

📒 Files selected for processing (1)
  • .github/workflows/test-module.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The module test workflow adds an optional saucebase_ref input, defaulting to main. The workflow uses this value when checking out Saucebase.

Changes

Module test Saucebase ref

Layer / File(s) Summary
Configure Saucebase checkout ref
.github/workflows/test-module.yml
The workflow adds the optional saucebase_ref input with a main default. The Saucebase checkout uses the selected ref.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to c6b6a

Module tests can select a Saucebase ref without changing the default checkout. No actionable merge risk remains beyond normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to c6b6a

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/test-module.yml: Adds the optional saucebase_ref workflow input, a string defaulting to main, for selecting the Saucebase branch, tag, or commit.
  • observed — Modified behavior in .github/workflows/test-module.yml: The Saucebase checkout now uses the caller-provided saucebase_ref instead of always checking out main.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing module tests to select the Saucebase ref.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@sauce-base
sauce-base merged commit 6c30989 into main Sep 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants