Skip to content

Add branding assets, update app views, and improve UI consistency - #382

Merged
roble merged 11 commits into
dev-v3from
sc-705-brand-assets-and-settings
Sep 14, 2026
Merged

roble merged 11 commits into
dev-v3from
sc-705-brand-assets-and-settings

Conversation

@roble

@roble roble commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces several visual and dependency improvements, focusing on a more flexible and brand-agnostic logo component, enhanced theme transitions, and updated package versions. It also cleans up the codebase by removing unnecessary logic and improving accessibility and user experience in the header and footer components.

Visual and Branding Improvements:

  • Refactored AppLogo to always render artwork (logo or icon) with the site name embedded in the image, removing all logic for rendering or coloring the name in text. The logo now supports two variants: a wide lockup (logo) and a square mark (icon), with CSS handling light/dark theme switching to avoid hydration flashes. (resources/js/react/components/AppLogo.tsx resources/js/react/components/AppLogo.tsxL2-L319)
  • Updated AppBrand and Header to use the new AppLogo API, removing direct references to the site name and ensuring the correct logo variant is shown depending on sidebar state or header usage. (resources/js/react/components/AppBrand.tsx [1] [2]; resources/js/react/components/Header.tsx [3]
  • Simplified the Footer watermark to always use the site name in a single style, removing custom branding logic. (resources/js/react/components/Footer.tsx resources/js/react/components/Footer.tsxL61-L70)

Theming and Animations:

  • Added a CSS animation for theme transitions, creating a circle reveal effect from the clicked option for smoother and more visually appealing theme changes. (resources/css/transitions.css resources/css/transitions.cssR25-R52)

Dependency Updates and Build Process:

  • Updated several dependencies in composer.json to newer versions for improved stability and features, including laravel/framework, larastan/larastan, laravel/boost, laravel/pint, and phpunit/phpunit. Also, narrowed the saucebase/core requirement. (composer.json composer.jsonL9-R23)
  • Removed an unused path repository entry from composer.json to clean up package resolution. (composer.json composer.jsonL129-L136)
  • Split the test task in Taskfile.yml into test:php and test:e2e for more granular control over test runs. (Taskfile.yml Taskfile.ymlL121-R122)

Accessibility and UX:

  • Improved accessibility in the header by ensuring that when the authentication modal opens, the trigger button is blurred to avoid focus remaining in an aria-hidden subtree. (resources/js/react/components/Header.tsx [1] [2]
  • Changed the logout link to submit as a POST button for better semantics and accessibility. (resources/js/react/components/Header.tsx resources/js/react/components/Header.tsxL149-R162)

- Added new SVG logo for light background: `logo-on-light.svg`.
- Updated app views for both React and Vue to use new branding logic:
  - Replaced general settings icon retrieval with brand-specific methods.
  - Updated title and description to use brand properties.
- Introduced end-to-end tests for branding assets to ensure correct loading of icons and titles.
- Removed outdated dashboard and general settings tests that were reliant on mutable state.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8a8c7e31-8fb1-4163-bb55-7cef287c2ceb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roble

roble commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

…-and-settings

# Conflicts:
#	composer.lock

Co-authored-by: roble <3231587+roble@users.noreply.github.com>

Copilot AI commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in e181e4b.

@sonarqubecloud

Copy link
Copy Markdown

@roble
roble merged commit 9eb1da6 into dev-v3 Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants