Add branding assets, update app views, and improve UI consistency - #382
Conversation
- Added new SVG logo for light background: `logo-on-light.svg`. - Updated app views for both React and Vue to use new branding logic: - Replaced general settings icon retrieval with brand-specific methods. - Updated title and description to use brand properties. - Introduced end-to-end tests for branding assets to ensure correct loading of icons and titles. - Removed outdated dashboard and general settings tests that were reliant on mutable state.
… branding in various components
…roved compatibility
… improved UI consistency
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot resolve the merge conflicts in this pull request |
…-and-settings # Conflicts: # composer.lock Co-authored-by: roble <3231587+roble@users.noreply.github.com>
Resolved in |
…/saucebase-dev/saucebase into sc-705-brand-assets-and-settings
|



This pull request introduces several visual and dependency improvements, focusing on a more flexible and brand-agnostic logo component, enhanced theme transitions, and updated package versions. It also cleans up the codebase by removing unnecessary logic and improving accessibility and user experience in the header and footer components.
Visual and Branding Improvements:
AppLogoto always render artwork (logo or icon) with the site name embedded in the image, removing all logic for rendering or coloring the name in text. The logo now supports two variants: a wide lockup (logo) and a square mark (icon), with CSS handling light/dark theme switching to avoid hydration flashes. (resources/js/react/components/AppLogo.tsxresources/js/react/components/AppLogo.tsxL2-L319)AppBrandandHeaderto use the newAppLogoAPI, removing direct references to the site name and ensuring the correct logo variant is shown depending on sidebar state or header usage. (resources/js/react/components/AppBrand.tsx[1] [2];resources/js/react/components/Header.tsx[3]Footerwatermark to always use the site name in a single style, removing custom branding logic. (resources/js/react/components/Footer.tsxresources/js/react/components/Footer.tsxL61-L70)Theming and Animations:
resources/css/transitions.cssresources/css/transitions.cssR25-R52)Dependency Updates and Build Process:
composer.jsonto newer versions for improved stability and features, includinglaravel/framework,larastan/larastan,laravel/boost,laravel/pint, andphpunit/phpunit. Also, narrowed thesaucebase/corerequirement. (composer.jsoncomposer.jsonL9-R23)composer.jsonto clean up package resolution. (composer.jsoncomposer.jsonL129-L136)Taskfile.ymlintotest:phpandtest:e2efor more granular control over test runs. (Taskfile.ymlTaskfile.ymlL121-R122)Accessibility and UX:
resources/js/react/components/Header.tsx[1] [2]resources/js/react/components/Header.tsxresources/js/react/components/Header.tsxL149-R162)