Skip to content

Sc 702 move config to core - #381

Merged
sauce-base merged 9 commits into
dev-v3from
sc-702-move-config-to-core
Sep 12, 2026
Merged

sauce-base merged 9 commits into
dev-v3from
sc-702-move-config-to-core

Conversation

@roble

@roble roble commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

This pull request removes several files and traits related to custom commands, helpers, facades, and settings pages, as well as some utility classes and traits. The main impact is a significant cleanup of legacy or unused code, especially around module management, Filament admin settings, and helper utilities. This likely prepares the codebase for a new approach or a major refactor in these areas.

Key removals and changes:

Module and Command Cleanup:

  • Removed the GenerateModuleTypesCommand and SeedModulesCommand, which handled TypeScript type generation and database seeding for modules. [1] [2]
  • Deleted the ModulePlugin trait and ModulesPlugin class, which provided dynamic registration and bootstrapping of Filament plugins for modules. [1] [2]

Filament Admin and Settings:

  • Removed the GeneralSettings and LocalizationSettings Filament admin pages, as well as the shared SettingsPage base class, which provided settings navigation and form schemas. [1] [2] [3]

Helpers and Utilities:

  • Deleted the Toast helper class for showing notifications and the global module_path helper function. [1] [2]

Facades and Service References:

  • Removed the Navigation facade, which provided a static interface to the navigation service.
  • Updated IndexController to use Saucebase\Core\Services\FrontendConfig instead of the local App\Services\FrontendConfig.

# Conflicts:
#	composer.json
#	composer.lock
…ation

- Deleted IndexControllerTest, InertiaSSRTest, LocalizationSettingsTest, SettingsInfrastructureTest, SettingsModalTest, SettingsNavigationTest, and RecipeToModuleCommandTest due to redundancy or changes in application structure.
- Introduced RouteAccessTest to validate authentication requirements for application routes.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 086501a1-6a9e-4b90-900c-7c26a65753fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@sauce-base
sauce-base merged commit 13830c8 into dev-v3 Sep 12, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants