chore: drop Telescope, dead debug config, and hand-maintained license files [sc-643] [sc-650] [sc-638] - #377
Conversation
… files Removes tooling and bookkeeping that every downstream app inherited without asking for it. [sc-643] Remove Telescope from the main app: package, config, service provider, the migration that created three telescope_* tables, the dont-discover block, and the TELESCOPE_ENABLED lines in CI and phpunit.xml. AppServiceProvider::register() held nothing else, so the method goes too. Anyone who wants Telescope can require it as a dev dependency. [sc-650] Delete THIRD_PARTY_LICENSES.md and THIRD_PARTY_PACKAGE_LICENSES.md. Both were hand-maintained and had already drifted (laravel/framework listed as ^12.0, tinker as ^2.10, spatie/laravel-data missing entirely). Saucebase distributes source, so vendor/ and node_modules/ are installed from upstream with each package's own LICENSE intact and no attribution obligation goes unmet. README now points at `composer licenses` and `npx license-checker --production` instead. [sc-638] Drop the explicit guzzlehttp/guzzle require. It was a workaround for Socialite lagging a Laravel upgrade; socialite v5.31.0 accepts guzzle ^8.0 (laravel/socialite#792) and laravel/framework v13 requires guzzle outright, so the pin protected nothing. Unpinning resolves guzzle to 8.1.0. Also removes config/debugbar.php (338 lines configuring a package present in neither composer.json nor the lock), its DEBUGBAR_ENABLED entry in .env.example, and the PULSE_ENABLED / NIGHTWATCH_ENABLED test env vars for packages that are not installed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
💤 Files with no reviewable changes (10)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change removes Laravel Telescope and Debugbar configuration, dependencies, providers, migration, and environment settings. It deletes manually maintained third-party license files and adds license reporting commands to the README. ChangesObservability tooling cleanup
License documentation update
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes unused observability tooling and stale license tables while documenting generated dependency-license reports. The remaining configuration and documentation changes are consistent with the stated cleanup and are ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
.editorconfig sets insert_final_newline = true, and phpunit.xml was the only top-level file violating it. Pre-existing, fixed here since this branch already touches the file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Three tickets from epic 517, all "remove things the main app shouldn't carry".
13 files, +130 −964.
[sc-643] Remove Telescope
laravel/telescopewas a dev dependency every downstream Saucebase app inherited, along with a config file, a service provider, a gate, and a shipped migration creating threetelescope_*tables. Removed:laravel/telescopefromrequire-devand the now-emptyextra.laravel.dont-discoverblockapp/Providers/TelescopeServiceProvider.php,config/telescope.phpdatabase/migrations/0001_01_01_000005_create_telescope_entries_table.phpAppServiceProvider::register()— it held nothing but the Telescope registrationTELESCOPE_ENABLEDfrom CI's generated.envand fromphpunit.xmlAnyone who wants Telescope can
composer require --dev laravel/telescope.[sc-650] Replace the license files
THIRD_PARTY_LICENSES.mdandTHIRD_PARTY_PACKAGE_LICENSES.mdwere hand-maintained tables that had already drifted — they listedlaravel/framework ^12.0(actually^13.29),laravel/tinker ^2.10(actually^3.0), and omittedspatie/laravel-dataandspatie/laravel-typescript-transformerentirely.They also weren't required: Saucebase distributes source,
vendor/andnode_modules/are gitignored and installed from upstream with each package's own LICENSE intact, so no attribution obligation was unmet. A generated NOTICE only becomes load-bearing if we start shipping built artifacts.Both files are deleted. The README
## Licensesection now points at the two commands that produce the truth on demand:[sc-638] Drop the explicit guzzle require
The
guzzlehttp/guzzle: ^7.8.2pin was a workaround for Socialite lagging behind a Laravel upgrade. That's fixed upstream —laravel/socialitev5.31.0 accepts^6.0|^7.0|^8.0(laravel/socialite#792) — andlaravel/frameworkv13 requires guzzle outright, so the pin protected nothing.ralouphie/getallheaders, addssymfony/polyfill-php82). That major bump is what the upstream fix unblocked, and it's what a freshcomposer create-projectwould pick anyway. Full suite passes on it. Flagging it since it's the one behavioural change in an otherwise subtractive PR.Also removed (dead config)
config/debugbar.php— 338 lines configuringbarryvdh/laravel-debugbar, which appears in neithercomposer.jsonnorcomposer.lockDEBUGBAR_ENABLED=falsefrom.env.example— a flag nothing readPULSE_ENABLED/NIGHTWATCH_ENABLEDfromphpunit.xml— same, for uninstalled packagesVerification
php artisan test --compactvendor/bin/pint --dirtyphp artisan migrate:fresh000005php artisan aboutcomposer validateanimate-pulseTailwind classes)Docs updates land separately in the docs repo:
testing-guide.mddocumented the now-removedTELESCOPE_ENABLED/PULSE_ENABLEDtest vars, andtroubleshooting.mdrecommendedphp artisan debugbar:publish.Note: existing installs keep their orphan
telescope_*tables — correct for a starter kit, where the goal is that new installs never get them.🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores