Skip to content

chore: drop Telescope, dead debug config, and hand-maintained license files [sc-643] [sc-650] [sc-638] - #377

Merged
roble merged 2 commits into
mainfrom
renanroble/sc-643-sc-650-remove-telescope-and-licenses
Sep 5, 2026
Merged

roble merged 2 commits into
mainfrom
renanroble/sc-643-sc-650-remove-telescope-and-licenses

Conversation

@roble

@roble roble commented Sep 5, 2026 •

Copy link
Copy Markdown
Collaborator

Three tickets from epic 517, all "remove things the main app shouldn't carry".

13 files, +130 −964.

[sc-643] Remove Telescope

laravel/telescope was a dev dependency every downstream Saucebase app inherited, along with a config file, a service provider, a gate, and a shipped migration creating three telescope_* tables. Removed:

  • laravel/telescope from require-dev and the now-empty extra.laravel.dont-discover block
  • app/Providers/TelescopeServiceProvider.php, config/telescope.php
  • database/migrations/0001_01_01_000005_create_telescope_entries_table.php
  • AppServiceProvider::register() — it held nothing but the Telescope registration
  • TELESCOPE_ENABLED from CI's generated .env and from phpunit.xml

Anyone who wants Telescope can composer require --dev laravel/telescope.

[sc-650] Replace the license files

THIRD_PARTY_LICENSES.md and THIRD_PARTY_PACKAGE_LICENSES.md were hand-maintained tables that had already drifted — they listed laravel/framework ^12.0 (actually ^13.29), laravel/tinker ^2.10 (actually ^3.0), and omitted spatie/laravel-data and spatie/laravel-typescript-transformer entirely.

They also weren't required: Saucebase distributes source, vendor/ and node_modules/ are gitignored and installed from upstream with each package's own LICENSE intact, so no attribution obligation was unmet. A generated NOTICE only becomes load-bearing if we start shipping built artifacts.

Both files are deleted. The README ## License section now points at the two commands that produce the truth on demand:

composer licenses
npx license-checker --production

[sc-638] Drop the explicit guzzle require

The guzzlehttp/guzzle: ^7.8.2 pin was a workaround for Socialite lagging behind a Laravel upgrade. That's fixed upstream — laravel/socialite v5.31.0 accepts ^6.0|^7.0|^8.0 (laravel/socialite#792) — and laravel/framework v13 requires guzzle outright, so the pin protected nothing.

⚠️ Unpinning re-resolves guzzle 7.15.5 → 8.1.0 (drops ralouphie/getallheaders, adds symfony/polyfill-php82). That major bump is what the upstream fix unblocked, and it's what a fresh composer create-project would pick anyway. Full suite passes on it. Flagging it since it's the one behavioural change in an otherwise subtractive PR.

Also removed (dead config)

  • config/debugbar.php — 338 lines configuring barryvdh/laravel-debugbar, which appears in neither composer.json nor composer.lock
  • DEBUGBAR_ENABLED=false from .env.example — a flag nothing read
  • PULSE_ENABLED / NIGHTWATCH_ENABLED from phpunit.xml — same, for uninstalled packages

Verification

Check Result
php artisan test --compact 126 passed, 352 assertions
vendor/bin/pint --dirty passed
php artisan migrate:fresh 9 migrations clean without 000005
php artisan about boots, no Telescope
composer validate valid
grep for telescope/debugbar/pulse/nightwatch clean (only animate-pulse Tailwind classes)

Docs updates land separately in the docs repo: testing-guide.md documented the now-removed TELESCOPE_ENABLED/PULSE_ENABLED test vars, and troubleshooting.md recommended php artisan debugbar:publish.

Note: existing installs keep their orphan telescope_* tables — correct for a starter kit, where the goal is that new installs never get them.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated the README with an MIT License section and commands for reviewing third-party package licenses.
    • Simplified the README links section.
    • Removed the manually maintained third-party license listings.
  • Chores

    • Removed Laravel Telescope and Debugbar configuration, setup settings, service registration, and database migration.
    • Removed related test and environment flags for Telescope, Debugbar, Pulse, and Nightwatch.

… files

Removes tooling and bookkeeping that every downstream app inherited without
asking for it.

[sc-643] Remove Telescope from the main app: package, config, service
provider, the migration that created three telescope_* tables, the
dont-discover block, and the TELESCOPE_ENABLED lines in CI and phpunit.xml.
AppServiceProvider::register() held nothing else, so the method goes too.
Anyone who wants Telescope can require it as a dev dependency.

[sc-650] Delete THIRD_PARTY_LICENSES.md and THIRD_PARTY_PACKAGE_LICENSES.md.
Both were hand-maintained and had already drifted (laravel/framework listed
as ^12.0, tinker as ^2.10, spatie/laravel-data missing entirely). Saucebase
distributes source, so vendor/ and node_modules/ are installed from upstream
with each package's own LICENSE intact and no attribution obligation goes
unmet. README now points at `composer licenses` and
`npx license-checker --production` instead.

[sc-638] Drop the explicit guzzlehttp/guzzle require. It was a workaround for
Socialite lagging a Laravel upgrade; socialite v5.31.0 accepts guzzle ^8.0
(laravel/socialite#792) and laravel/framework v13 requires guzzle outright,
so the pin protected nothing. Unpinning resolves guzzle to 8.1.0.

Also removes config/debugbar.php (338 lines configuring a package present in
neither composer.json nor the lock), its DEBUGBAR_ENABLED entry in
.env.example, and the PULSE_ENABLED / NIGHTWATCH_ENABLED test env vars for
packages that are not installed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 116567f8-3371-4574-829b-0615f572378a

📥 Commits

Reviewing files that changed from the base of the PR and between 5c250b6 and d6d9981.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • .env.example
  • .github/actions/setup-laravel/action.yml
  • README.md
  • THIRD_PARTY_LICENSES.md
  • THIRD_PARTY_PACKAGE_LICENSES.md
  • app/Providers/AppServiceProvider.php
  • app/Providers/TelescopeServiceProvider.php
  • composer.json
  • config/debugbar.php
  • config/telescope.php
  • database/migrations/0001_01_01_000005_create_telescope_entries_table.php
  • phpunit.xml
💤 Files with no reviewable changes (10)
  • database/migrations/0001_01_01_000005_create_telescope_entries_table.php
  • THIRD_PARTY_PACKAGE_LICENSES.md
  • .github/actions/setup-laravel/action.yml
  • config/debugbar.php
  • composer.json
  • app/Providers/AppServiceProvider.php
  • .env.example
  • app/Providers/TelescopeServiceProvider.php
  • THIRD_PARTY_LICENSES.md
  • config/telescope.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes Laravel Telescope and Debugbar configuration, dependencies, providers, migration, and environment settings. It deletes manually maintained third-party license files and adds license reporting commands to the README.

Changes

Observability tooling cleanup

Layer / File(s) Summary
Remove observability tooling setup
.env.example, .github/actions/setup-laravel/action.yml, app/Providers/AppServiceProvider.php, app/Providers/TelescopeServiceProvider.php, composer.json, config/debugbar.php, config/telescope.php, database/migrations/0001_01_01_000005_create_telescope_entries_table.php, phpunit.xml
Debugbar and Telescope configuration, providers, dependencies, migration, environment values, and setup wiring are removed.

License documentation update

Layer / File(s) Summary
Replace maintained license tables
README.md, THIRD_PARTY_LICENSES.md, THIRD_PARTY_PACKAGE_LICENSES.md
The README adds the MIT license statement and Composer and npm license-reporting commands. The manually maintained license files are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d6d99

This change removes unused observability tooling and stale license tables while documenting generated dependency-license reports. The remaining configuration and documentation changes are consistent with the stated cleanup and are ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: removing Telescope, unused debug configuration, and manually maintained license files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renanroble/sc-643-sc-650-remove-telescope-and-licenses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

.editorconfig sets insert_final_newline = true, and phpunit.xml was the only
top-level file violating it. Pre-existing, fixed here since this branch already
touches the file.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@roble
roble merged commit 2839e1f into main Sep 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant