Skip to content

Remove package overrides from package.json for cleaner dependency man… - #375

Merged
roble merged 2 commits into
mainfrom
dev-improvements
Aug 30, 2026
Merged

roble merged 2 commits into
mainfrom
dev-improvements

Conversation

@roble

@roble roble commented Aug 30, 2026 •

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements to user registration visibility in both the React and Vue front-end components, as well as dependency updates in the backend and project stubs. The main focus is to ensure that the "Get Started" (registration) link is only shown to guests when registration is enabled, and to keep dependencies up to date and clean.

User registration visibility improvements:

  • The "Get Started" registration link in the React Header.tsx component is now only displayed to guests if registration_enabled is true in the authentication props. This applies to both desktop and mobile navigation. [1] [2] [3] [4]
  • The Vue Header.vue component now conditionally displays the registration link only if registration_enabled is true, for both desktop and mobile views. [1] [2]

Dependency updates and cleanup:

  • Added guzzlehttp/guzzle version ^7.8.2 to composer.json to ensure HTTP client availability in the backend.
  • Removed unnecessary overrides entries from the React and Vue stack package.json stubs for a cleaner dependency tree. [1] [2]

Summary by CodeRabbit

  • New Features
    • Registration links now appear in desktop and mobile navigation only when account registration is enabled.
    • Guests will no longer see “Get Started” options when registration is unavailable.
  • Bug Fixes
    • Improved navigation behavior to consistently respect server-configured registration availability across supported interfaces.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fcb55bfb-3896-4fd6-aa43-d2c1350518d4

📥 Commits

Reviewing files that changed from the base of the PR and between 0d9b452 and ed5ba92.

⛔ Files ignored due to path filters (3)
  • composer.lock is excluded by !**/*.lock
  • stubs/saucebase/stack/react/package-lock.json is excluded by !**/package-lock.json
  • stubs/saucebase/stack/vue/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • composer.json
  • resources/js/react/components/Header.tsx
  • resources/js/vue/components/Header.vue
  • stubs/saucebase/stack/react/package.json
  • stubs/saucebase/stack/vue/package.json
💤 Files with no reviewable changes (2)
  • stubs/saucebase/stack/vue/package.json
  • stubs/saucebase/stack/react/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change gates React and Vue registration links with the server registration setting. It adds Guzzle to Composer dependencies and removes npm package overrides from the React and Vue stub manifests.

Changes

Registration visibility

Layer / File(s) Summary
Gate header registration links
resources/js/react/components/Header.tsx, resources/js/vue/components/Header.vue
React and Vue desktop and mobile registration links now require registration_enabled. React derives this condition through canRegister.

Dependency updates

Layer / File(s) Summary
Update dependency manifests
composer.json, stubs/saucebase/stack/react/package.json, stubs/saucebase/stack/vue/package.json
Composer now requires guzzlehttp/guzzle version ^7.8.2. The React and Vue stub manifests no longer define npm overrides for @hono/node-server, tar, and shell-quote.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ed5ba

The PR gates registration links on the registration setting and cleans up dependency declarations while keeping the Composer lockfile consistent. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the removal of package overrides from the React and Vue package.json files. It does not mention the registration visibility changes or the Guzzle dependency, but it clea…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title accurately describes the removal of package overrides from the React and Vue package.json files. It does not mention the registration visibility changes or the Guzzle dependency, but it clearly identifies a real and significant part of the changeset.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roble
roble merged commit c2df14f into main Aug 30, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant