Remove package overrides from package.json for cleaner dependency man… - #375
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change gates React and Vue registration links with the server registration setting. It adds Guzzle to Composer dependencies and removes npm package overrides from the React and Vue stub manifests. ChangesRegistration visibility
Dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR gates registration links on the registration setting and cleans up dependency declarations while keeping the Composer lockfile consistent. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Title checkExplanation The title accurately describes the removal of package overrides from the React and Vue package.json files. It does not mention the registration visibility changes or the Guzzle dependency, but it clearly identifies a real and significant part of the changeset. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request introduces several improvements to user registration visibility in both the React and Vue front-end components, as well as dependency updates in the backend and project stubs. The main focus is to ensure that the "Get Started" (registration) link is only shown to guests when registration is enabled, and to keep dependencies up to date and clean.
User registration visibility improvements:
Header.tsxcomponent is now only displayed to guests ifregistration_enabledis true in the authentication props. This applies to both desktop and mobile navigation. [1] [2] [3] [4]Header.vuecomponent now conditionally displays the registration link only ifregistration_enabledis true, for both desktop and mobile views. [1] [2]Dependency updates and cleanup:
guzzlehttp/guzzleversion^7.8.2tocomposer.jsonto ensure HTTP client availability in the backend.overridesentries from the React and Vue stackpackage.jsonstubs for a cleaner dependency tree. [1] [2]Summary by CodeRabbit