Skip to content

fix: keep docker stub publishing silent during install [sc-636] - #25

Merged
roble merged 2 commits into
mainfrom
renanroble-sc-636-fix-docker-publish-non-interactive
Sep 5, 2026
Merged

roble merged 2 commits into
mainfrom
renanroble-sc-636-fix-docker-publish-non-interactive

Conversation

@roble

@roble roble commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #24 — this commit was pushed to the branch after that PR merged, so it never landed on main.

The bug

Command::call() builds an ArrayInput, which defaults to interactive, and Illuminate only flips it via createInputFromArguments() when a --no-interaction key is present. Symfony's Command::run() does not parse that flag itself.

So after #24, DockerEnvironment::publishStubs() delegating to docker:publish would have prompted docker-compose.yml already exists. Overwrite it? on a re-install in a real terminal. The install flow has always skipped existing files silently.

The test suite could not catch this: TestCase::artisan() always calls setInteractive(false), so context() propagated --no-interaction down and the prompt never fired under test.

The fix

Pass '--no-interaction' => true explicitly from publishStubs(), plus a regression test asserting the flag is set. Also restores the full no-SSL warn message that was truncated in #24.

203 tests / 400 assertions passing.

Story: https://app.shortcut.com/saucebase/story/636

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Docker environment setup now runs without overwrite prompts, preserving existing Docker files automatically.
    • Disabled SSL configurations now correctly apply the no-SSL Nginx configuration.
    • Improved guidance is shown when the no-SSL configuration cannot be copied because Docker stubs have not been published.

Command::call() only disables interactivity when --no-interaction is
passed, so delegating to docker:publish would have prompted the user to
overwrite existing Docker files on a re-install. The install flow has
always skipped existing files silently — force non-interactive mode and
cover it with a regression test.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: d30679af-1beb-4e2c-b368-8d21cecdd8bb

📥 Commits

Reviewing files that changed from the base of the PR and between 3385f9f and 5dc046f.

📒 Files selected for processing (3)
  • src/Console/Commands/PublishDockerCommand.php
  • src/Environments/DockerEnvironment.php
  • tests/Feature/Environments/DockerEnvironmentTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Docker stub publishing now forces non-interactive execution. Existing files remain unchanged without prompts. The no-SSL copy failure warning includes a hint to publish Docker stubs first. A feature test verifies the delegated command options.

Changes

Docker stub publishing

Layer / File(s) Summary
Non-interactive publish delegation
src/Environments/DockerEnvironment.php, src/Console/Commands/PublishDockerCommand.php, tests/Feature/Environments/DockerEnvironmentTest.php
publishStubs passes --no-interaction to docker:publish. The no-SSL copy warning includes a publication hint. The feature test verifies the publish path, SSL option, and non-interactive option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to 5dc04

Docker stub publishing is intended to remain silent during reinstalls, but the new regression test appears to use a differently spelled interaction option than the implementation. Resolve the test/implementation mismatch before merging so the non-interactive behavior is reliably covered.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: keeping Docker stub publishing silent during installation. It is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renanroble-sc-636-fix-docker-publish-non-interactive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roble
roble merged commit 18fd154 into main Sep 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant