Add translatability tests for email login notifications - #51
Merged
Merged
Conversation
…-feature-to-send-email-when-login Renanroble sc 472 auth add feature to send email when login
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that sends login notification emails to users when they sign in, enhancing account security. It adds a configurable setting that allows administrators to enable or disable these notifications via the authentication settings page. The implementation includes event-driven notification dispatch, localization, and comprehensive tests.
Key changes:
Login Notification Feature Implementation
ReturningUserAuthenticatedevent, which is dispatched after a user logs in through any supported method (standard login, magic link, or social authentication). [1] [2] [3] [4]SendLoginNotificationlistener that sends aLoginNotificationemail to the user if the feature is enabled in settings.LoginNotificationnotification class, which includes contextual information (login time, IP address, device details), uses localization, and is queued for delivery.Settings and Admin Interface
login_notification_enabledboolean property toAuthSettings, with a corresponding database migration and UI toggle in the authentication settings page. [1] [2] [3]Localization
Testing
LoginNotification, covering content, localization, queuing, and fallback behaviors.Controller and Event Integration
These changes collectively improve user security awareness and provide administrators with control over notification preferences.