Conversation
…igation sort for AuthenticationSettings and UserResource
…d tests for email verification
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (32)
💤 Files with no reviewable changes (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughMagic-link enablement and expiry now use persisted ChangesAuthentication settings and authentication flow
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🔵 Low · up to The new authentication settings tests may interfere with parallel test projects by sharing mutable settings, which could cause misleading or flaky verification results. The PR is mergeable with explicit owner awareness or follow-up to ensure project-wide test isolation. Sequence Diagram(s)sequenceDiagram
participant Administrator
participant AuthenticationSettings
participant AuthSettings
participant MagicLinkController
participant MagicLinkNotification
Administrator->>AuthenticationSettings: Save magic-link settings
AuthenticationSettings->>AuthSettings: Persist settings
MagicLinkController->>AuthSettings: Read expiry and enablement
MagicLinkController->>MagicLinkNotification: Pass URL and expiry
MagicLinkNotification-->>Administrator: Render expiry in email
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 PHPStan (2.2.8)Composer install failed: the lock file is not up to date with the latest changes in composer.json. Run Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces configurable magic link authentication settings and refactors the authentication card layout to use a shared core component in both React and Vue implementations. It also improves the user experience on the email verification page and updates Filament admin navigation and settings management for authentication.
Magic Link Authentication Configuration:
AuthSettings(withmagic_link_enabledandmagic_link_expiry), replacing the previous static config. Magic links default to a 15-minute expiry and can be managed by administrators through a newAuthenticationSettingsFilament page. (CLAUDE.md[1] [2];config/config.php[3];database/settings/2026_07_30_160000_create_auth_settings.php[4];src/Filament/Pages/AuthenticationSettings.php[5];src/Http/Controllers/MagicLinkController.php[6]Filament Admin Improvements:
AuthenticationSettingspage for managing magic link settings, and updates navigation icons and sort orders for authentication-related resources. Removes direct navigation group configuration fromAuthPlugin. (CLAUDE.md[1];src/Filament/AuthPlugin.php[2] [3];src/Filament/Pages/AuthenticationSettings.php[4];src/Filament/Resources/Users/UserResource.php[5] [6]Authentication Card Layout Refactor:
AuthCardLayoutcomponents to use a sharedCardLayoutcore component, simplifying code and allowing for consistent UI across modules. The wrapper remains for module-specific vocabulary and future customizations. (resources/js/react/layouts/AuthCardLayout.tsx[1] [2];resources/js/vue/layouts/AuthCardLayout.vue[3] [4]Email Verification Page UX Improvements:
resources/js/react/pages/VerifyEmail.tsx[1] [2];resources/js/vue/pages/VerifyEmail.vue[3] [4]Minor UI and Code Cleanups:
resources/js/react/pages/Register.tsx[1];resources/js/vue/pages/Register.vue[2];resources/js/vue/app.ts[3]Summary by CodeRabbit
New Features
Bug Fixes
Tests