Repository navigation
fix(web): factory chips keep the 4px corner in the tick dialogs - #812
Merged
Merged
Conversation
…logs A factory chip with nothing to click fell back to the pill shape, so the 'Also tick the export?' dialog drew its factory as a pill unlike every other factory chip. FactoryChip now always takes the 4px corner, which lets LinkedTickSyncDialog drop its own override. The dialog's Cancel is red text to match the dismiss-button convention. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpK4T9JcLjzM9GoTeiHFTP
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Maelstromeous
marked this pull request as ready for review
October 15, 2026 17:55
The link reads exporting factory -> item for an export and item -> importing factory for an import, with an arrow in place of from/into. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpK4T9JcLjzM9GoTeiHFTP
…chip Ticking and unticking share one dialog titled 'Also update the export/import?' under the export (truck) or import icon. The separate 'Also mark as' switch is gone: the other factory's chip carries a tick already showing the state Apply leaves it in, and clicking it changes the outcome. Declining that factory's checklist clears the tick, and ticking it again turns the checklist back on. The link stays on one line, with a long factory name ellipsed first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpK4T9JcLjzM9GoTeiHFTP
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: the "Also tick the export/import?" dialog drew the other factory as a rounded pill, unlike the 4px-corner factory chips in the imports and exports tables. Its Cancel button was plain white text.
After: the factory chip is the same 4px-corner chip used everywhere else, with its group colour on the left edge, and Cancel is red text like every other dismiss button.
A
FactoryChipwithclickablefalse fell back to the app's default pill shape, so every non-clickable factory chip was a pill. #798 worked round this with a local override inLinkedTickSyncDialog.How:
FactoryChipnow always sets the 4px corner itself, so the override inLinkedTickSyncDialogis gone. The other non-clickable factory chips (Global Factories Summary rows, the Shards & Sloops statistics) pick up the same corner, in line with the rule that factory chips are never pills.Screenshots are in the project thread (demo plan, Circuit Boards, ticking the Copper Sheet import).
🤖 Generated with Claude Code
https://claude.ai/code/session_01NpK4T9JcLjzM9GoTeiHFTP
Generated by Claude Code