fix: ensure leading blanks are always imported - #434
Merged
Merged
Conversation
Member
Author
|
Test results: ℹ Tests provided results: 125/125 (100%) |
|
🎉 This PR is included in version 4.68.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two cases where leading blanks in character data were silently stripped during web service input/output, and relaxes an over-strict test assertion.
Changes
meta/mm_createwebservice.sas & server/ms_createwebservice.sas
JSON export now retains leading blanks
Previously, non-special character values were exported using quote(cats(...)), which strips leading blanks. Replaced with '"'!!trim(...)!!'"' so leading blanks are preserved while trailing blanks are still trimmed.
Table imports now use $char informat
The generated input statement used a plain $ informat, which strips leading blanks on import. A prxchange now rewrites :$ informats to :$char in the captured input statement, ensuring leading blanks in incoming data are retained.
tests/base/mp_jsonout.test.3.sas
Verification