Bind CD deploy job to production environment so AWS deploy config resolves at runtime - #5
Merged
Merged
Conversation
Co-authored-by: sanket-rajput <100849898+sanket-rajput@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job "Deploy to Production EC2"
Bind CD deploy job to Aug 25, 2026
production environment so AWS deploy config resolves at runtime
sanket-rajput
approved these changes
Aug 25, 2026
sanket-rajput
marked this pull request as ready for review
August 25, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Deploy to Production EC2job failed in Actions becauseAWS_REGION(and related deploy config) resolved empty at runtime, causingconfigure-aws-credentialsto error before deployment began. This PR scopes the deploy job to the intended GitHub environment and clarifies config placement in deployment docs.Workflow: ensure environment-scoped deploy config is available
.github/workflows/deploy.ymlto run the deploy job in theproductionenvironment.AWS_REGIONEC2_SECURITY_GROUP_IDDocs: clarify where deploy configuration must live
deploy/README.mdto explicitly state that environment-level values must be set in theproductionenvironment for this workflow.