Skip to content

Fix CD deploy workflow failure when AWS region/security-group are configured as repository variables #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanket-rajput merged 2 commits into from
Aug 25, 2026
Merged

Fix CD deploy workflow failure when AWS region/security-group are configured as repository variables #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda950e
Initial plan
Copilot Aug 25, 2026
5ab80aa
fix: allow deploy workflow to read AWS region and SG from vars
Copilot Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
name: Deploy to Production EC2
runs-on: ubuntu-latest
env:
AWS_REGION: ${{ secrets.AWS_REGION }}
EC2_SECURITY_GROUP_ID: ${{ secrets.EC2_SECURITY_GROUP_ID }}
AWS_REGION: ${{ vars.AWS_REGION || secrets.AWS_REGION }}
EC2_SECURITY_GROUP_ID: ${{ vars.EC2_SECURITY_GROUP_ID || secrets.EC2_SECURITY_GROUP_ID }}

steps:
- name: Configure AWS credentials
Expand Down
2 changes: 2 additions & 0 deletions deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ The deployment workflow (`.github/workflows/deploy.yml`) temporarily whitelists
Required repository secrets for this automation:
- `AWS_ACCESS_KEY_ID`
- `AWS_SECRET_ACCESS_KEY`

Required repository variables (or secrets) for this automation:
- `AWS_REGION`
- `EC2_SECURITY_GROUP_ID`

Expand Down
Loading