Repository navigation
feat: show images in SSH status, remove roles per run, reject unused --tag - #2
Merged
Merged
Conversation
…--tag - Managed SSH `status` includes each container's image. Only secret values are redacted now: deploys record the secret variable names (never values) in `.compoza.json`. Stacks deployed by earlier versions keep redacting every dotenv value. Service and image patterns are fully anchored, and longer values are redacted before shorter ones. - `destinations.<name>.roles.<role>: null` and `local.roles.<role>: null` remove a role for that run: no build, image, Git check, validation, override entry or allowlisted secrets. Removals are checked when the config loads, including unselected destinations. A role the selected destination removes stays removed for `--local`. - `--tag` fails when no role has a build, and naming a removed role says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #1, which added
roles.SSH
statusshows imagesWith
execution: sshand a managed secret source,statusprinted each container's service, state, health and exit code. It left out the image, so there was no way over SSH to see which role tag was running. It now includesimage.While adding the image, we found the redaction was too broad. It replaced every value from the stack
.env, including plainenvironmentsettings. A setting likeWEB_CONCURRENCY=2turnedshop-web:3f2a2b9into***-web:3f***a***b9, andPOSTGRES_USER=postgresturnedpostgres:16into***:16.secretNamesin.compoza.json. Status redacts only those values.secretNames, so they keep redacting every value until their next deploy.\A…\z, so a trailing newline no longer passes.(image).Remove a role for one run
A removed role isn't built, imaged, Git-checked or validated against the Compose files. It gets no override entry and no metadata tag, and its secrets are no longer added to a 1Password
variablesallowlist. If the Compose files still declare the service, it runs as they define it.check:Destination "staging" removes role "wrker", which is not a role; roles: web, worker.nullis only accepted under destination andlocalroles, not under the top-levelroles.--destination staging --local, a role the destination removes stays removed. Alocal.rolesnullfor it does nothing, andlocal.rolessettings for it are ignored.--tag--tagfails when no role has abuild, instead of being silently ignored:No role has a build, so there are no images to reuse; deploy without --tag.Role "worker" is removed for this run, so --tag cannot name it.Testing
pnpm checkpasses.pnpm test: 543 passed, 2 skipped.pnpm packpluspnpm test:packagepass.deploy.yml--destinationcombined with--local--tagerrorslocal.rolesboth removingworkerbuilds onlyweb;--tag worker=abcon the removed role fails as above; a typo in a destination failscheck.No real SSH host was used; status redaction was tested with fake
docker compose psoutput.Docs
docs/configuration.md,docs/secrets.md,docs/ssh-deployment.md,docs/commands.md, thestatushelp text and both copies of the compoza skill describe the new behavior.