Feat: SEL-362X Module by fspardo · Pull Request #79 · sandialabs/PEAT

fspardo · 2026-07-22T20:02:37Z

SEL-362X Module

Description

This PR aims to implement support for the SEL-362X family of products. While originally intended for the SEL-3622, this module ended up providing partial support for the SEL-3620. This module currently supports both products.

Please check the following items as they're completed.
Completion of all checklist items signals to maintainers that a PR is fully ready for review.

GhostofGoes · 2026-07-22T21:53:05Z

Thanks for opening a draft. Just a FYSA, my very first review comment will be asking you to squash those 285 glorious commits 😁

GhostofGoes · 2026-07-23T15:03:09Z

@@ -0,0 +1,521 @@
+# Configuration file for PEAT (the Process Extraction and Analysis Tool)


cut this config down to just the fields that have changed or are otherwise being used/are relevant.

fspardo · 2026-07-23T16:42:07Z

Main branch has been cold-pressed.

GhostofGoes · 2026-07-23T21:55:58Z

+    return AdvancedRange(low, high)
+
+
+class Method:


Encapsulating pull methods as objects is something I've wanted to do for a long time. Maybe you could be the chosen one and finally bring this to the PEAT API?!?!

Scan uses IdentifyMethod, but Pull is a basic override of Device._pull(). Instead of that nonsense, define PullMethod instances that the device can select and use based on configuration options, verification status, etc just like for IdentifyMethod and scan.

I may consider working on that eventually, if happenstance permits it.

GhostofGoes · 2026-07-27T19:52:01Z

note: remove email from docstrings, policy for peat is all requests should go to peat@sandia.gov (and also emails change and become stale)

fspardo · 2026-07-30T23:05:35Z

This should be ready for review, but I do not know why GitHub is preventing me from adding tags to the PR (which needs to be labeled as a feature addition).

GhostofGoes · 2026-07-31T03:33:54Z

This should be ready for review, but I do not know why GitHub is preventing me from adding tags to the PR (which needs to be labeled as a feature addition).

You likely can't tag because you're not a Maintainer for the project, just like I can't anymore 😅. No worries, @BugFriendlyGarden can tag/label as appropriate.

Can you please update the PR title to align with conventional commit style? e.g. "feat: 362x module"

I'll give this a proper review if I have some spare time tomorrow, otherwise it'll likely be next week. Fear not, there will definitely be comments 😈

GhostofGoes · 2026-07-31T03:38:19Z

Biggest issue tho before I review everything else is there are way too many source files. one-function-per-file is excessive, it leads to a lot of import-related boilerplate, duplication, and hard to trace code, not to mention super cluttered folder. Follow the pattern other modules have of consolidating related functions into a single file or small set of files, e.g. data-model related functions in a "362x_processing" and data parsing in "362x_parsing.py".

I leave the approach up to you.

fspardo · 2026-07-31T15:13:29Z

Biggest issue tho before I review everything else is there are way too many source files. one-function-per-file is excessive, it leads to a lot of import-related boilerplate, duplication, and hard to trace code, not to mention super cluttered folder.

There were other requirements (namely collaboration) that I had to consider for this project, but it should be fairly straightforward to fix this.

fspardo · 2026-07-31T16:26:47Z

I have reduced this to six files. Do let me know if that is still too much.

GhostofGoes · 2026-07-31T19:39:46Z

+Author: Francisco Santana
+"""
+
+# TODO: This needs to be updated to better support the SEL-3620 or R212 of the firmware.


Create a github issue to track this. if you can, include in the issues more details about what issues you ran into specifically (make sure not to include any sensitive info, if you're uncertain talk with your project lead). This is so someone picking up your work in the future has somewhere to start.

GhostofGoes

Ok, this is a big review. Don't take it the wrong way, you did great work here, and it made me want to give it a proper deep review. You really dug deep into the device and got a lot of information. Good work on error handling, type annotations, and comments.

GhostofGoes · 2026-07-31T19:43:30Z

+    peat_module: "sel-362x"
+    options:
+      https:
+        port: 10443


I interacted with the 3620 using SSH port forwarding, though I could change it to 443.

yeah change to 443, this is meant to be a general example

GhostofGoes · 2026-07-31T19:44:48Z

+"""
+SEL-362X Family of Security Gateways.
+
+This module is designed to support both the SEL-3622 and the SEL-3620, though


One major concern I have is the module name. There is already a module for the SEL-3620.

Does the 362X module also work with the 3620?

If so, then the modules need to be combined.

If not, probably should differentiate this module somehow, e.g. rename to SEL3622.

The plan is to replace the 3620 module eventually, but keep the old one for compatibility for now.

Can you document that somewhere? My concern is if there's a 3620 on the network, there could be two peat modules activated simultaneously, with odd results. Have you tested against the peat rack with all modules enabled? e.g. peat pull -i <rack-subnet> (all defaults)

This module seemingly takes precedence over the 3620 module due to the higher reliability rating. For now, I removed the aliases to the 3620 on my module.

GhostofGoes · 2026-07-31T19:45:50Z

+was originally developed for the former.
+
+Authors:
+    - Francisco Santana


If Nehal contributed code, both of you should be added to the AUTHORS file

GhostofGoes · 2026-07-31T19:50:27Z

+
+class SEL362X(DeviceModule):
+    """
+    SEL-3620 Security Gateway


see earlier comment about duplication with SEL3620

GhostofGoes · 2026-07-31T19:50:45Z

+    vendor_id = "SEL"
+    vendor_name = "Schweitzer Engineering Laboratories"
+    brand = "SEL"
+    module_aliases = ["sel-3622", "sel-3620", "sel-362x", "3622", "3620", "362x"]


this overlaps with the existing SEL3620 module

I removed aliases for the 3620.

GhostofGoes · 2026-07-31T20:43:43Z

+    return result
+
+
+def parse_free_mem(lines: list[str]) -> dict[str, Any]:


dev.hardware (see SELRTAC for example)

GhostofGoes · 2026-07-31T20:44:07Z

+    return result
+
+
+def parse_process_list(lines: list[str]) -> list[dict[str, Any]]:


dev.related.process

GhostofGoes · 2026-07-31T20:48:32Z

+
+def pull_syslog_settings(dev: DeviceData, session: HTTP362X) -> dict[str, Any]:
+    """
+    Pull the configuration under /Syslog.sel


You can probably re-use a lot of the parsing and processing code from SEL3620 and SELRTAC modules.

GhostofGoes · 2026-07-31T20:49:10Z

 Releases
 ========

+- Added support for pulling and parsing configuration data for the SEL-3622/3620 Security Gateway (Tested for Firmware R200 and R212, respectively)


This should be a towncrier snippet. Was a relatively recent change to peat, talk to @BugFriendlyGarden

I should probably ask him about that. Thanks for telling me!

Yeah, the change is documented in CONTRIBUTING.rst under Update the CHANGELOG.

I'm working on making the new requirement clear. You just need to put your new text above into a file called newsfragments/79.feature

When we create the next release, we'll run a tool called towncrier that digests all of the newsfragments files to automatically update the CHANGELOG.rst file.

Good to know. I just added a file to my repo -- feel free to correct it.

GhostofGoes · 2026-07-31T20:49:33Z

    {file = "tomlkit-0.14.0.tar.gz", hash = "sha256:cf00efca415dbd57575befb1f6634c4f42d2d87dbba376128adb42c121b87064"},
 ]

-[[package]]


revert changes to pdm.lock

Restored from upstream 👍

BugFriendlyGarden · 2026-07-31T22:43:20Z

This should be ready for review, but I do not know why GitHub is preventing me from adding tags to the PR (which needs to be labeled as a feature addition).

You likely can't tag because you're not a Maintainer for the project, just like I can't anymore 😅. No worries, @BugFriendlyGarden can tag/label as appropriate.

@GhostofGoes Does tag in this case only refer to release tags? It's the only one I see in CONTRIBUTING.md.

GhostofGoes · 2026-08-03T23:07:54Z

This should be ready for review, but I do not know why GitHub is preventing me from adding tags to the PR (which needs to be labeled as a feature addition).

You likely can't tag because you're not a Maintainer for the project, just like I can't anymore 😅. No worries, @BugFriendlyGarden can tag/label as appropriate.

@GhostofGoes Does tag in this case only refer to release tags? It's the only one I see in CONTRIBUTING.md.

Labels is the proper term.

+def do_hash(hcons: Callable[..., _Hash], data: str) -> str:
+    """Get a HASH object from `hcons`, then make a digest of `data`"""
+    hobj = hcons(usedforescurity=False)
+    hobj.update(data.encode())


GhostofGoes reviewed Jul 23, 2026

View reviewed changes

fspardo force-pushed the main branch from cba373e to eb86274 Compare July 23, 2026 16:41

fspardo force-pushed the main branch from eb86274 to eda14a0 Compare July 23, 2026 16:47

GhostofGoes reviewed Jul 23, 2026

View reviewed changes

fspardo force-pushed the main branch from eda14a0 to 31c40cb Compare July 23, 2026 22:31

fspardo force-pushed the main branch 8 times, most recently from 4d84aef to a44d10c Compare July 30, 2026 23:02

fspardo marked this pull request as ready for review July 30, 2026 23:02

fspardo changed the title ~~SEL-362X Module~~ ADDITION: SEL-362X Module Jul 30, 2026

fspardo force-pushed the main branch from a44d10c to 8d31cfc Compare July 30, 2026 23:09

fspardo changed the title ~~ADDITION: SEL-362X Module~~ Feat: SEL-362X Module Jul 31, 2026

fspardo force-pushed the main branch from 8d31cfc to 8d3851e Compare July 31, 2026 16:24

fspardo force-pushed the main branch from 8d3851e to 6cb006d Compare July 31, 2026 16:42

GhostofGoes reviewed Jul 31, 2026

View reviewed changes

GhostofGoes mentioned this pull request Jul 31, 2026

[Feature] Data model ideas #48

Open

9 tasks

GhostofGoes suggested changes Jul 31, 2026

View reviewed changes

fspardo force-pushed the main branch 7 times, most recently from e317810 to d79bbef Compare July 31, 2026 22:12

fspardo force-pushed the main branch 2 times, most recently from a4293e2 to f1700e1 Compare August 3, 2026 19:17

BugFriendlyGarden added the enhancement New feature or request label Aug 4, 2026

fspardo force-pushed the main branch 3 times, most recently from 34397cf to 6cd692c Compare August 7, 2026 19:40

362X module

f58ce1d

fspardo force-pushed the main branch from 6cd692c to f58ce1d Compare August 7, 2026 19:42

Merge remote-tracking branch 'upstream/main' to fix AUTHORS conflict

e4f6442

github-advanced-security AI found potential problems Aug 14, 2026

View reviewed changes

Comment thread peat/modules/sel/sel_362X/__init__.py

def do_hash(hcons: Callable[..., _Hash], data: str) -> str:

"""Get a HASH object from `hcons`, then make a digest of `data`"""

hobj = hcons(usedforescurity=False)

hobj.update(data.encode())

		@@ -0,0 +1,521 @@
		# Configuration file for PEAT (the Process Extraction and Analysis Tool)

		return result


		def parse_free_mem(lines: list[str]) -> dict[str, Any]:

		return result


		def parse_process_list(lines: list[str]) -> list[dict[str, Any]]:

Uh oh!

Conversation

fspardo commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SEL-362X Module

Description

Uh oh!

GhostofGoes commented Jul 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fspardo commented Jul 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GhostofGoes commented Jul 27, 2026

Uh oh!

fspardo commented Jul 30, 2026

Uh oh!

GhostofGoes commented Jul 31, 2026

Uh oh!

GhostofGoes commented Jul 31, 2026

Uh oh!

fspardo commented Jul 31, 2026

Uh oh!

fspardo commented Jul 31, 2026

Uh oh!

GhostofGoes Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GhostofGoes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BugFriendlyGarden commented Jul 31, 2026

Uh oh!

GhostofGoes commented Aug 3, 2026

Uh oh!

fspardo commented Jul 22, 2026 •

edited

Loading

GhostofGoes Jul 31, 2026 •

edited

Loading