feat: add MySQL/MariaDB protocol class - #62
Merged
BugFriendlyGarden merged 1 commit intoAug 24, 2026
Conversation
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
2 times, most recently
from
May 8, 2026 16:29
0307579 to
9be85dc
Compare
GhostofGoes
suggested changes
May 27, 2026
GhostofGoes
left a comment
GhostofGoes
left a comment
Contributor
There was a problem hiding this comment.
Some other requests:
- Has this been tested extensively against a OT device/system running MySQL? What SQL server instances has it been tested against (if you can share in open-source)
- Add references to new class to developer API documentation
- Add a documentation page dedicated to MySQL
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
from
June 12, 2026 18:15
9be85dc to
217291c
Compare
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
from
June 25, 2026 17:48
217291c to
c844009
Compare
Contributor
Author
This has not been tested against an OT device running MySQL. The implementation was validated against a standard MySQL instance running in Docker. The class is designed as a base class — device-specific subclasses are expected to override on_connected() and enumerate() to query proprietary tables relevant to a particular device. Testing against specific OT targets is left to those subclasses. |
Contributor
|
Add a GitHub Actions workflow that spawns a MySQL container and executes tests against it |
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
3 times, most recently
from
August 3, 2026 18:20
2048256 to
7aa7109
Compare
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
2 times, most recently
from
August 20, 2026 23:02
ad00988 to
70498bb
Compare
GhostofGoes
approved these changes
Aug 21, 2026
GhostofGoes
left a comment
GhostofGoes
left a comment
Contributor
There was a problem hiding this comment.
I'd like to see an example module that adds to the data model, eg Users
- MySQL wrapper around PyMySQL with lazy connection via conn property - Bound logger, __enter__/__exit__ context manager support - on_connected and enumerate hooks for subclass customization - Helper methods: get_databases, get_tables, get_table_row_count, get_users, get_grants, get_global_variables, get_process_list - read_greeting staticmethod for unauthenticated banner fingerprinting - Plain-function pytest suite covering all public methods and hooks - Integration tests (test_mysql_integration.py) tagged with container marker for running against a live MySQL instance - MySQL integration test job added to tests-container.yml, spinning up MySQL 8.0 as a service container on push/PR Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jgallagheriii
force-pushed
the
feat/mysql-protocol
branch
from
August 24, 2026 15:46
70498bb to
7403f7c
Compare
BugFriendlyGarden
approved these changes
Aug 24, 2026
Collaborator
|
This PR has been approved by the team so we're going to merge it in without a module that directly utilizes the new capability. We can do that later when it comes up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MySQL/MariaDB protocol class
Description
Please include a summary of the changes made.
Related Issue
Closes #59
Checklist
Please check the following items as they're completed.
Completion of all checklist items signals to maintainers that a PR is fully ready for review.
CHANGELOG.rst