Repository navigation
fix: repair E2B runtime builds and stabilize preparation tests - #25
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 151651c8b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MCODE_HARNESS_BUILD_DIR="$(python3 -c 'import json,sys; print(json.load(open(sys.argv[1]))["mcode"])' "$inputs")" | ||
| CLAUDE_SDK_BUILD_DIR="$output_root/claude-sdk" | ||
| export AGENTS_RUNTIME_CODEX_PACKAGE MCODE_HARNESS_BUILD_DIR CLAUDE_SDK_BUILD_DIR | ||
| export AGENTS_RUNTIME_CODEX_PACKAGE CODEX_CLI_DIR MCODE_HARNESS_BUILD_DIR CLAUDE_SDK_BUILD_DIR |
There was a problem hiding this comment.
For both main and beta builds, this exports the same Codex package path under the current and legacy process-setting names even though the selected builder consumes only one. Select the builder first and pass only CODEX_CLI_DIR or AGENTS_RUNTIME_CODEX_PACKAGE to that invocation; this preserves branch support without introducing a second environment-variable alias for the datum.
AGENTS.md reference: AGENTS.md:L53-L57
Useful? React with 👍 / 👎.
sam2tom
changed the title
1 participant
Summary
The E2B template workflow must invoke the current Codex runtime builder and provide the source package directory it expects. Export
CODEX_CLI_DIRfrom the prepared inputs and usescripts/build-codex-runtime.shalongside the Claude and MiniMax builders so template publication can build current main and beta sources.Two preparation lifecycle tests used 60/80ms admission deadlines that could expire during workspace setup on loaded CI workers. Give both fixtures a 2s deadline and wait beyond the returned
ExpiresAtin the transfer test. Preserve the expiry, stale-handle rejection, and transferred-session ownership assertions without changing production code.Validation
make check-namesand actionlint 1.7.12 passed.go test -race ... -count=10(41.746s).git diff --checkpassed; fresh independent review of the complete diff found no P1/P2 issues.9527854fc26788da852ac00e996eac14b6a1a621: https://github.com/sandbaseai/OpenAgentCore/actions/runs/38120381126 (25 successful jobs, including runtime and the aggregate check).