Repository navigation
Add configurable weighted track path finder with on-demand search, diagnostics, persisted settings, and path cost controls - #6
Conversation
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/184d8d9d-d9eb-4abe-9328-cd87262fa315 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/184d8d9d-d9eb-4abe-9328-cd87262fa315 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
|
@copilot please address the following feedback:
|
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/0beaaa16-de27-4aa2-b17c-6905062c34ca Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/0beaaa16-de27-4aa2-b17c-6905062c34ca Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Addressed in Implemented:
Screenshot: |
|
@copilot there's the following issues:
|
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/c7c66bfa-ce5f-4da5-9ec7-484eaae5f0fd Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/c7c66bfa-ce5f-4da5-9ec7-484eaae5f0fd Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Addressed in Implemented:
Screenshot: |
|
@copilot for some of the tracks listed as 'no bpm' I don't quite understand how that comes about. Here's one example that shows up without BPM, but it's 122.0: |
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/c5027592-d30f-4e33-a337-71e6be0b77be Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/c5027592-d30f-4e33-a337-71e6be0b77be Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
... Great catch — you’re absolutely right about the two BPM columns. I fixed this in The importer now explicitly prefers |
|
@copilot can you please also calculate the average cost and the max cost per step for each path, allow paths to be sorted by total cost, average cost, or max cost, and allow to set a max cost per step (default 4) and a max average cost (default 3). |
| "name": "keybpmmap", | ||
| "private": true, | ||
| "version": "0.4.0", | ||
| "version": "0.7.0", |
There was a problem hiding this comment.
@copilot We only need to bump the version once per PR. Keep this at 0.5.0
There was a problem hiding this comment.
Done in 51ae953 — version is now 0.5.0 in both package.json and package-lock.json.
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/c9ee4396-4ba1-4b45-9ff7-6918daf261fa Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
| <div className="field-grid path-weight-grid"> | ||
| {PATH_WEIGHT_FIELDS.map((field) => { | ||
| const helpText = `${field.description}${ | ||
| field.exampleFrom && field.exampleTo | ||
| ? ` Example: ${formatVisibleKey(field.exampleFrom)} → ${formatVisibleKey(field.exampleTo)}.` | ||
| : ` ${field.exampleText ?? ''}` | ||
| }` | ||
|
|
||
| return ( | ||
| <label key={field.key}> | ||
| <span className="path-weight-label-row"> | ||
| <span className="path-weight-label-text"> | ||
| {formatWeightLabel(field.key, field.label, keyRepresentation)} | ||
| </span> | ||
| <span | ||
| className="path-weight-tooltip" | ||
| title={helpText} | ||
| aria-label={helpText} | ||
| tabIndex={0} | ||
| > | ||
| ⓘ | ||
| </span> | ||
| </span> | ||
| <input | ||
| type="number" | ||
| step="0.1" | ||
| value={pathFinderSettings.weights[field.key]} | ||
| onChange={(event) => handlePathWeightChange(field.key, event.target.value)} | ||
| /> | ||
| </label> | ||
| ) | ||
| })} | ||
| </div> |
There was a problem hiding this comment.
@copilot Group these under a heading "Transition costs"
There was a problem hiding this comment.
Done in 7f650de — added a "Transition costs" heading above the weight inputs grid.
|
@copilot make pathfinder wording consistent: don't use 'step' and 'transition', only 'transition'; don't use 'cost' and 'weight', only 'weight' |
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/6b24eb82-37a1-457b-a10d-0afbad309981 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/a5323fbd-82b5-40ca-b0e2-e86c9d64c87c Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Done in |
@copilot this was actually happening on 'main' as well and I didn't notice. Please add a badge for this workflow to the README.md as well |
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/4c4f051e-14d8-4cc6-95ce-f196aed9ad54 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Done in |
@copilot actually, I changed my mind. Use "cost" instead of "weight", I think that makes more sense to the average user |
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/5163e6e8-3214-4939-853c-4d2bf28445d0 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Done in |
textAnchorvalue"beginning"→"start"(valid SVG/TS value)Original prompt
This pull request was created from Copilot chat.