Repository navigation
Add selectable key notation with persistence, introduce conversion/format unit tests, and run tests in PR/main CI - #5
Conversation
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/21d25a8e-6102-4cba-8831-53f23a5e791c Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
There was a problem hiding this comment.
@copilot Just noticed in passing that this list doesn't fill the article vertically if it's long, it only uses about half of the vertical space within the article
There was a problem hiding this comment.
Adjusted in commit 8e52647: the sparse/missing regions list now grows to fill the insight panel’s available vertical space (with scrolling), instead of being capped to about half height.
Screenshot: /tmp/keybpmmap-sparse-list-fill.png.
…map labels Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/12d6e354-e0ed-42c4-8949-ae17d73de92c Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/a669965a-a897-4628-921f-1658af8d1948 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
| const label = formatKeyLabel(camelotKey) | ||
| const rotateLabel = label.length > 3 | ||
| const labelY = height - margin.bottom + 28 | ||
| return ( | ||
| <text | ||
| key={camelotKey} | ||
| x={x} | ||
| y={height - margin.bottom + 28} | ||
| textAnchor="middle" | ||
| y={labelY} | ||
| textAnchor={rotateLabel ? 'start' : 'middle'} | ||
| className="chart-label" | ||
| transform={rotateLabel ? `rotate(90 ${x} ${labelY})` : undefined} | ||
| > | ||
| {formatKeyLabel(camelotKey)} | ||
| {label} |
There was a problem hiding this comment.
@copilot There's a large gap between the rotated labels and the bottom of the heatmap and some of the labels are cropped at the bottom of the container because they are too far down
There was a problem hiding this comment.
Adjusted in commit 6db0ed5: rotated heatmap key labels now anchor upward and use a tighter y-offset, which removes the extra gap and prevents bottom clipping.
Screenshot: /tmp/keybpmmap-heatmap-rotated-labels-spacing.png.
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/affed9f7-f289-483e-916a-8bee4c0d5802 Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.