Repository navigation
Dashboard: label the prefetch lane meter Utilization and add its sparkline - #356
Merged
Merged
Conversation
…kline The Prefetch System pane's meter shows the share of the prefetch lane in use, 0% at rest to 100% with every slot busy. It was labelled Capacity, which names the fixed size rather than the share in use. The row now reads Utilization, with its indent dropped so its values align with the Prefetch row above. Beside the meter a sparkline shows the lane's utilization over the last twelve seconds. The dashboard draws every 100 ms, so a per-draw history like the other panes' would cover 1.2 s, too short to read a trend from; LaneHistory averages each second into one cell instead and draws the open second live. Cells scale against a full lane rather than the recent peak, so a half-busy lane always draws at half height and agrees with the percentage beside it. Closes #355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #355
What
The Prefetch System pane's meter row reads
Utilizationinstead ofCapacity, with its indent dropped so its values align with thePrefetchrow above. Beside the meter a sparkline shows the lane's utilization over the last twelve seconds.Two choices a reviewer cannot read off the diff:
LaneHistoryaverages each second into a cell and draws the open second live, so the row covers 12 s and still moves on the next draw.Verification
make pre-commitclean: fmt, clippy with-D warnings, full workspace tests.Prefetchrow, the sparkline position in the row, per-second averaging, absolute scaling, the 12-second window and an unknown lane size reading as idle.CHANGELOG entry under Unreleased.