Repository navigation
Raise FaradayServerError on 5xx in multipart adapter - #58
Open
povilasjurcys wants to merge 1 commit into
Open
povilasjurcys wants to merge 1 commit into
povilasjurcys wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml
Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml Warning: unrecognized cop RSpec/MultipleMemoizedHelpers found in .rubocop.yml Error: RuboCop found unknown Ruby version 3.1 in `TargetRubyVersion` parameter (in .rubocop.yml). Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
povilasjurcys
marked this pull request as ready for review
September 28, 2026 15:52
matas-simonaitis
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
GraphlientMultipartAdapterregistersFaraday::Response::RaiseErrorviac.adapter(notc.use), so it never runs. A 5xx from a proxy (e.g. an HTML 503 page) is returned as the body and blows up later as a bareJSON::ParserErrorinGraphQL::Client#query.This PR drops the no-op line and raises
Graphlient::Errors::FaradayServerError(withstatus_code) for 5xx responses. 4xx responses are deliberately still returned as the body, since they may carry GraphQL errors the model layer handles today — switching toRaiseErrorwould change that.