fix: Fix publication of macos/ios targets. SddsSbCom Theme were updated. - #879
Conversation
📝 WalkthroughWalkthroughThis change moves release jobs to macOS, adds Compose API metadata annotations, removes the standalone API metadata module, updates token gradients and theme ordering, and increments Compose artifact versions with archived documentation records. ChangesCompose release and token updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish-all-tokens-release.yml:
- Line 21: Add a job-level permissions block granting only contents: write to
every listed release job: publish-tokens in
.github/workflows/publish-all-tokens-release.yml, publish-haze in
.github/workflows/publish-haze-release.yml, generate-distribution in
.github/workflows/publish-icons-compose-release.yml, the integration sandbox
Compose job in
.github/workflows/publish-integration-sandbox-compose-release.yml, the
integration sandbox core job in
.github/workflows/publish-integration-sandbox-core-release.yml, and
publish-uikit in .github/workflows/publish-uikit-compose-release.yml. No other
permissions are needed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fe02f8a8-b42b-4b86-93fb-fd53207a879d
📒 Files selected for processing (36)
.github/workflows/publish-all-tokens-release.yml.github/workflows/publish-haze-release.yml.github/workflows/publish-icons-compose-release.yml.github/workflows/publish-integration-sandbox-compose-release.yml.github/workflows/publish-integration-sandbox-core-release.yml.github/workflows/publish-uikit-compose-release.yml.gitignoregradle/libs.versions.tomlsdds-core/api-info-compose/build.gradle.ktssdds-core/settings.gradle.ktssdds-core/uikit-compose/build.gradle.ktssdds-core/uikit-compose/gradle.propertiessdds-core/uikit-compose/src/commonMain/kotlin/com/sdds/api/info/compose/ApiInfo.kttokens/plasma-stards-compose/docs/override-docs/versionsArchived.jsontokens/plasma-stards-compose/gradle.propertiestokens/plasma.giga.compose/docs/override-docs/versionsArchived.jsontokens/plasma.giga.compose/gradle.propertiestokens/plasma.homeds.compose/docs/override-docs/versionsArchived.jsontokens/plasma.homeds.compose/gradle.propertiestokens/plasma.sd.service.compose/docs/override-docs/versionsArchived.jsontokens/plasma.sd.service.compose/gradle.propertiestokens/sdds-sbcom-compose/.sdds/theme-info-compose.jsontokens/sdds-sbcom-compose/docs/override-docs/versionsArchived.jsontokens/sdds-sbcom-compose/gradle.propertiestokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/SddsSbComColors.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/SddsSbComGradients.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/SddsSbComSpacing.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/subthemes/SddsSbComThemeInverse.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/subthemes/SddsSbComThemeOnDark.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/theme/subthemes/SddsSbComThemeOnLight.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/tokens/ColorTokens.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/tokens/GradientTokens.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/tokens/SpacingTokens.kttokens/sdds-sbcom-compose/src/main/kotlin/com/sdds/sbcom/tokens/TypographyTokens.kttokens/sdds.serv.compose/docs/override-docs/versionsArchived.jsontokens/sdds.serv.compose/gradle.properties
💤 Files with no reviewable changes (3)
- sdds-core/settings.gradle.kts
- sdds-core/uikit-compose/build.gradle.kts
- sdds-core/api-info-compose/build.gradle.kts
📦 Собранные Release APK
📲 Как установить APK на Android-устройство:
💻 Установка через USB (ADB):
|
|
📘Артефакты документации опубликованы: |
What/why changed
Проблема: iOS-артефакты в Maven Central не опубликованы. Публикационный workflow запускается на ubuntu-latest. Apple Native publications должны собираться на macOS.
Summary by CodeRabbit
New Features
Release Updates
Bug Fixes
Chores