fix(permissions): Permissions on sources and keys - #84
Open
sir-ragna wants to merge 2 commits into
Open
Conversation
On systems with a restrictive umask the sources.list files and gpg key files can become unreadable. This is an issue because even when invoking `apt` with root permissions, `apt` will drop permissions to perform signature validation. Without read permission on the gpg key files this fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
If you currently rely on
umaskto keep your files unreadable for unprivileged users on your system, you will need to reconfigure the default in the pillar. Seeapt:mode_sources_list.Describe the changes you're proposing
We had issues in our environment due to a restrictive umask causing the keys not to be readable. This breaks apt because apt drops privileges when doing key verifications. The keys need to have the permissions
0644.In our environment we also want to keep our sources files set to
0644. We recognized that some people might not like this, due to embeded credentials in their sources files. Hence an option was added, so that the rest of our changes could get upstreamed.Pillar / config required to test the proposed changes
The option
apt:mode_sources_listwas added to set the mode of all sources files.Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context
Somewhat related to the
pkgrepo.managedfeature request to get amodeproperty.We figured it'd take too long to actually implement and upstream such request, that we'd be better off doing these things in the formula for now.