test(acp-setup): cover the runtime toolchain install reprobing the adapter - #236
Merged
Merged
Conversation
…apter The component step owns the runtime install, and installing its toolchain is what supplies the package manager an npx adapter needs. The adapter is probed on step entry, before that install, so without a re-probe its stale "no package manager" verdict keeps its own install button disabled on a machine that now has everything it asked for. The behaviour had no test of its own. Reverse verified: suppressing RequestAdapterReprobeAfterRuntimeChange turns this test red. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component step now owns the agent runtime install, and installing its toolchain is what supplies the package manager an npx adapter needs. The adapter is probed on step entry — before that install — so without a re-probe its stale "no package manager" verdict keeps its own install button disabled on a machine that now has everything it asked for.
The behaviour shipped in 96cfe86 without a test of its own. This adds one; reverse verification is recorded in the commit message — suppressing RequestAdapterReprobeAfterRuntimeChange turns it red.
🤖 Generated with Claude Code