fix(slo): validate Destination at typed receivers - #97
Draft
salasebas wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Destinationvalidation in typedreceive_sloandfinish_sloflows for both SP and IdP rolesDestinationonce the binding or root XML signature authenticates the messageFlowResultas context-limited and caller-owned for actual-endpoint comparisonWhy
The concern behind #87 is real at the typed receiver boundary, but raw/typed parity is not the right contract. The typed facade knows the local role, binding, metadata endpoint, peer, and transaction; the raw compatibility parser does not receive the actual endpoint.
Previously, typed SLO compared only a present
Destinationafter parsing. A signed message could therefore omit the attribute and reach successful typed handling. Moving the comparison into the authenticated flow supplies the missing receiver context and guarantees rejection before replay state is written.Standards
Destinationwith the actual recipientDestinationCompatibility
Destinationremains available only through explicit compatibility policy where the binding permits unsigned inputValidation
cargo fmt --all --checkcargo clippy -p saml-rs --all-targets -- -D warningscargo nextest run -p saml-rs— 753 passedcargo test -p saml-rs --docRUSTDOCFLAGS="-D warnings -D missing_docs" cargo doc -p saml-rs --lib --all-features --no-depscargo test -p saml-rs --doc --no-default-featurescargo check -p saml-rs --no-default-features