fix(auth): sync account cookies with session cache - #137
Draft
salasebas wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream evidence
Compared only with Better Auth v1.6.23 at commit
9dfceee14021fc15a2fb93023f39635f25b0b5ba:packages/better-auth/src/cookies/index.tsrenews or expiresaccount_dataafter session-cache writes and skips synchronization when the response already has a pending account cookie.packages/better-auth/src/context/store-capabilities.tstreats database or secondary storage as a server session store, but only a database as a server account store.packages/better-auth/src/api/routes/account.tsapplies session-user binding only when a database exists.PR #124 coordination
PR #124 owns the built-in social callback changes in
routes/social.rbandsocial_test.rb. This PR does not touch those files. Its pending-cookie guard is the compatibility boundary that preserves the fresh account cookie written by that social flow.Checks
git diff --check: passed