Skip to content

Fix corrupt session cache fail-closed parity - #134

Draft
salasebas wants to merge 1 commit into
mainfrom
salasebas/parity-redis-13-corrupt-session-cache
Draft

Fix corrupt session cache fail-closed parity#134
salasebas wants to merge 1 commit into
mainfrom
salasebas/parity-redis-13-corrupt-session-cache

Conversation

@salasebas

Copy link
Copy Markdown
Owner

Summary

  • distinguish a secondary-session-cache miss from a present corrupt value before database fallback
  • preserve pinned Better Auth v1.6.23 JavaScript truthiness and one-pass safeJSONParse control flow
  • add real dual-storage regressions for missing, corrupt, raw/decoded falsy, and doubly encoded cache values

Upstream parity

Compared against Better Auth v1.6.23 at 9dfceee14021fc15a2fb93023f39635f25b0b5ba.

Verification

  • bundle exec ruby -Ipackages/better_auth/lib -Ipackages/better_auth/test packages/better_auth/test/better_auth/adapters/internal_adapter_test.rb — 40 runs, 164 assertions
  • BUNDLE_GEMFILE=Gemfile bundle exec rake test in packages/better_auth — 1,546 runs, 9,435 assertions
  • bundle exec standardrb
  • git diff --check
  • fresh blind scoped review — Approve

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
better-auth Ignored Ignored Aug 20, 2026 9:53pm

@github-actions github-actions Bot added the core label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant