Repository navigation
fix: do not treat annotations as branch failures - #130
Merged
Merged
Conversation
This was referenced Oct 3, 2026
Owner
|
Hi Mitch, thank you so much for your contribution! I will review and integrate your MR next. It might take some time though as I have not much to spare and there a lot of changes. Best, |
fitchmultz
force-pushed
the
fix/annotation-aware-branches
branch
from
October 14, 2026 02:19
4c65acb to
bf1f760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128.
When a subschema only produces annotations, such as
deprecated, the branch checks count it as a failure. As a result,oneOfrejects valid data,iffalls through toelse, andnotaccepts data it should reject.These checks now treat a branch as passing when everything it returns is an annotation (
isJsonAnnotation), instead of expecting an empty result. A pending async result still counts as a non-match, same as before. That covers:oneOfandanyOfvalidation and reductionifandnotcontainsandpropertyNamesAnnotation handling is otherwise unchanged.
Tests are in src/tests/issues/issue128.branch-annotations.test.ts. The JSON pointer escaping that used to be in this PR is now in #131.
AI disclosure: This pull request was prepared with AI assistance and reviewed by me.