Repository navigation
Conversation
A YAML row on the JSON tab: block style, 2-space indent, strings quoted only where a YAML reader would take them for something else (reserved words, numbers, dates, indicator characters, leading/trailing spaces), multi-line strings as | literal blocks. Follows the sort-keys option. Emitter output verified to round-trip through PyYAML.
CryptoJS's unpadding trusts the last byte, so a wrong key (the PBKDF2 reading of a legacy MD5-KDF payload, or a wrong password) unpadded cleanly about once in 120 tries and produced a few bytes of noise or an empty string instead of null — the legacy fallback was then skipped. Padding and UTF-8 are now checked before a result is accepted; the round-trip test that failed intermittently gets a fixed vector.
DATETIME rows get a calendar hint ("Wednesday · 2019-W09 · day 58 of
365", plus the zone offset on the local row). A Duration row reads a
bare number as seconds (milliseconds from 13 digits, like the rest of
the tab) and writes it out as "1d 1h 1m 1s"; the other way, "1h 30m",
"01:30:00", "PT1H30M" or "2 days, 3 hours" give seconds.
A leading seconds field (Quartz, Spring and friends) is accepted next to the classic five: the description reads "At 04:05:30" / "At every 10th second past every 5th minute", next runs are searched per second and shown with seconds, and the builder switches to custom expression, since it writes five fields. cron.parse() now always returns six fields; a five-field expression gets an implicit second 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 3, one commit per step:
yes,007,2024-01-01,a: b, leading/trailing spaces…), multi-line strings as|literal blocks; follows the sort-keys option. Output verified to round-trip through PyYAML.Wednesday · 2019-W09 · day 58 of 365, plus the zone offset on the local row. A Duration row: a bare number reads as seconds (90061→1d 1h 1m 1s, with the milliseconds reading in the hint) and the other way1h 30m,01:30:00,PT1H30M,2 days, 3 hours→ seconds.At 04:05:30,At every 10th second past every 5th minute), next runs searched per second and shown with seconds, builder falls to "custom expression".Tests: 241 (was 218).