Configurable sub-level assembly height (#938)#980
Open
tatoyoda600 wants to merge 1 commit into
Open
Conversation
Adds 2 config values, implementing suggestions 2 & 3 from ryanhcode#938: - SUB_LEVEL_START_POS: Determines the approach to use for determining the height (Y value) of the first block in a newly assembled sub-level (FIXED, DYNAMIC, MIDPOINT) - FIXED: Uses the height specified by SUB_LEVEL_FIXED_START_HEIGHT (Essentially the current approach) - DYNAMIC: Uses the world height of the position the block is in (Spawn a sub-level at Y=73, the block is placed at Y=73 in the sub-level) - MIDPOINT: Calculates the midpoint between the min and max build limits, then uses that as the height - SUB_LEVEL_FIXED_START_HEIGHT - If SUB_LEVEL_START_POS is set to FIXED, then this is the height (Default value of 128 matches the current approach)
|
|
Author
|
Implemented suggestion 1 from #938, but it kinda sucks, so not including in this PR (https://github.com/tatoyoda600/sable/tree/automatic-height-adjustment) It does help with the issue I was having in #938 though, as soon as the Rope Pulley reaches -64 in the sub-level, the sub-level's contents are shifted up to give it more downwards space to expand, letting my Rope Pulley reach real deep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 config values, implementing suggestions 2 & 3 from #938:
Defaults are 128 and FIXED, to match the current approach exactly, with all the customization being exclusively opt-in.
With dynamic assembly height, a 1-block sub-level created at Y=87 has its sole block located at Y=87 within the sub-level
