Skip to content

GitHub release - Source code assets are missing /libs/hbb_common submodule #701

Description

@SecurityCze

Describe the bug
GitHub releases of source code tarballs (both .zip. and .tar.gz) are missing the /libs/hbb_common submodule.

The folder is present, but is empty.

For example:
Source code (tar.gz) for version 1.1.16.
Image

This has been happening ever since version 1.1.13 (version 1.1.12 is the last one that contains the submodule)

Describe the environment
Source code releases from versions 1.1.13 (including) going forward.

How to Reproduce the bug
Steps to reproduce the behavior:

  1. Go to releases page
  2. Download a source code (.zip or .tar.gz)
  3. Unpack
  4. Observe contents of /libs/hbb_common directory is empty
  5. [optional] Attempt to build the application
error: failed to load manifest for workspace member `rustdesk-server-1.1.16/libs/hbb_common`

Expected behavior
Source release should contain every submodule required to build the application.

Additional context
I believe it is caused by GitHub not including git submodules in automatically generated source code tarballs.
Since 1.1.13 (specifically Commit 7a509f6) the hbb_common lib is added as a submodule.

Possible solution would be to build the tarballs manually inside the build workflow.

References:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions