Wayland, Windows, MacOS: Popup Implementation by Murmele · Pull Request #4543 · rust-windowing/winit

Murmele · 2026-03-25T06:58:46Z

Implement proper decorationless popups by specifying the type of the child window with with_type()

With this PR different kind of child windows can be created

Popups: Special windows without any decoration which can be positioned relative to the parent
Window: Normal window with a parent or not

The type can be specified during creation of the Window using the window_attributes and the with_type() function. As default a normal Window is used. If Popup is choosen a parent must be specified, otherwise the Popup creation fails with an Error returned by the new() function.

Related issues: #403 and #4256

Tested on all platforms changed
Added an entry to the changelog module if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality

Platforms

Wayland:

Bildschirmaufzeichnung.vom.2026-06-04.13-18-16.mp4

This work is sponsored by the NLnet foundation

Reason: Because a normal window can have a parent window as well, like a Dialog

…pups

Reason: otherwise the child surface is anchored to the center

Reason: otherwise the height of the client side decoration is not considered and therefore the location is shifted

Reason: There are multiple pointers to the smithay popup. Once in state.windows and one time in the popup object it self. Just dropping the popup object releases only one pointer but we have to notify the state to release also the other

…he position Reason: Much easier in the resize handle

Reason: we have to call resize to initialize the viewport to map to correct window size

Reason: Because wayland or the event loop could destroy the popup and therefore it is anymore available

Murmele · 2026-06-18T13:04:54Z

@kchibisov @CryZe @tronical

In 90ebef0 I implemented the correct popup order destroyment. I had the problem that the Popup Item it self contained a window state and therefore it got not delegated to the compositor that the popup shall be deleted. This I fixed in ac4a329 by storing only a Weak pointer of the window state in the Popup struct (popup_state: Weak<Mutex<WindowState>>).
What do you think about instead of returning a Box<dyn Window> returning a Weak pointer. So the event loop basically stores the state popup and the user has only a weak pointer and if the popup was destroyed for some reason (Parent destroyed, ...) then the pointer is invalid and the user is aware that it does not exist anymore?

kchibisov · 2026-06-18T16:12:21Z

What do you think about instead of returning a Box returning a Weak pointer. So the event loop basically stores the state popup and the user has only a weak pointer and if the popup was destroyed for some reason (Parent destroyed, ...) then the pointer is invalid and the user is aware that it does not exist anymore?

I like that you also came to a conclusion I had for the window storage, as in basically user has some handle but the Window itself is only owned by winit.

I'll think about it a bit since we want to plug it into the current design, but generally, I think that's how it should be, honestly, even though a lot of folks disagree with me on that matter...

Reason: Otherwise it will not be dropped

Murmele · 2026-07-01T10:04:04Z

What do you think about instead of returning a Box returning a Weak pointer. So the event loop basically stores the state popup and the user has only a weak pointer and if the popup was destroyed for some reason (Parent destroyed, ...) then the pointer is invalid and the user is aware that it does not exist anymore?

I like that you also came to a conclusion I had for the window storage, as in basically user has some handle but the Window itself is only owned by winit.

I'll think about it a bit since we want to plug it into the current design, but generally, I think that's how it should be, honestly, even though a lot of folks disagree with me on that matter...

Thanks! Just let me know whats your decision here

ogoffart · 2026-07-03T14:18:24Z

-                    mem::drop(window_requests.remove(window_id));
-                    mem::drop(state.windows.get_mut().remove(window_id));
-                    return Some(WindowEvent::Destroyed);
+            if self.with_state(|state| state.window_requests.get_mut().get(window_id).is_none()) {


Is there a reason why we call with_state several time?
I think this could be simplified maybe.

decided to keep it as it is for now

ogoffart · 2026-07-03T15:09:28Z

+    // If we have a popup the position is relative to the parent window and not
+    // relative to the screen. Therefore we have to translate it from the parent
+    // coordinate system to the display coordinate system
+    fn translate_outer_position(&self, position: Position) -> PhysicalPosition<i32> {


Looks like with_position(p) and a later set_outer_position(p) put the popup in two different places. The initial position needs the same translation.

Also outer_position() still returns screen coordinates, so the getter and setter now use different coordinate spaces. Probaly the getter needs to be translated too.

Or the documentation should be cristal clear about this difference. And we need to be somehow consistent across platforms if possible.

The initial position for win32 is set using the set_outer_position function:

if let Some(position) = attributes.position { win.set_outer_position(position); }

So that means the translate is done here. I will have a look into for the return value

The outer_position returns now for windows and macOs the position relative to the parent if it is a popup

ogoffart · 2026-07-03T15:13:57Z

    let parent = match attributes.parent_window() {
        Some(rwh_06::RawWindowHandle::Win32(handle)) => {
-            window_flags.set(WindowFlags::CHILD, true);
+            if !is_popup {


other platform return an error if there is no parents

fixed in 5e3b9f4

…opups

Otherwise for multiple seats it could happen that we don't grab the keyboard

madsmtm added DS - wayland Affects the Wayland backend, or generally free Unix platforms S - platform parity Unintended platform differences labels Mar 26, 2026

Murmele commented May 15, 2026

View reviewed changes

Comment thread winit-wayland/src/window/state.rs

Murmele commented May 15, 2026

View reviewed changes

Comment thread winit-wayland/src/window/state.rs Outdated

Murmele marked this pull request as ready for review May 18, 2026 08:06

Murmele requested a review from kchibisov as a code owner May 18, 2026 08:06

Murmele commented May 18, 2026

View reviewed changes

Comment thread winit-wayland/src/state.rs Outdated

Comment thread winit-wayland/src/state.rs Outdated

ogoffart reviewed May 18, 2026

View reviewed changes

Murmele commented May 26, 2026

View reviewed changes

Comment thread winit-win32/src/window.rs

Murmele requested a review from madsmtm as a code owner May 28, 2026 15:09

Murmele force-pushed the popup branch 2 times, most recently from facdfde to 87f6327 Compare June 4, 2026 12:59

Murmele added 15 commits June 4, 2026 15:07

initial commit to implement popup

bd6dea9

use dedicated type to determine if the window is a popup or not

ae3178c

Reason: Because a normal window can have a parent window as well, like a Dialog

determine the scale factor from the parent window

8f42bbc

add comment, thtat positioning is now also working on wayland with po…

933939a

…pups

set the positioner gravity

d43d6ad

Reason: otherwise the child surface is anchored to the center

cleanup

6dc05a7

consider the location of the frame for client side decoration

68e33bf

Reason: otherwise the height of the client side decoration is not considered and therefore the location is shifted

extend comment

a4d299b

fix closing popups

3514818

Reason: There are multiple pointers to the smithay popup. Once in state.windows and one time in the popup object it self. Just dropping the popup object releases only one pointer but we have to notify the state to release also the other

implement resizing of the popup using the positioner

a02e2c3

Positioner: Set anchor point once and then use the offset to change t…

9371aca

…he position Reason: Much easier in the resize handle

implement popup for macos

4eb2667

implement popup for windows

3c0d318

Fix popup size for different scalings

39e35d0

Reason: we have to call resize to initialize the viewport to map to correct window size

Merge commit 'c4afadbfabf7b1e7989b40b493db1a4c7bd8ff4e'

78bfc78

Murmele force-pushed the popup branch from 87f6327 to 78bfc78 Compare June 4, 2026 13:17

add changelog entry

9c33bdc

Murmele changed the title ~~Wayland: Popup Implementation~~ Wayland, Windows, MacOS: Popup Implementation Jun 4, 2026

Murmele added 2 commits June 18, 2026 14:57

implement correct order destroyment of popup childrens

90ebef0

Do not store the popup state in the Popup but only a weak pointer

ac4a329

Reason: Because wayland or the event loop could destroy the popup and therefore it is anymore available

Murmele force-pushed the popup branch from 5c8042b to ac4a329 Compare June 18, 2026 12:57

Murmele added 3 commits June 18, 2026 15:06

Fix clippy

90a4273

format

f856616

store serial of mouse input press/release and keyboard press/release

80bb34b

Murmele added 3 commits June 19, 2026 09:19

latest_serial() returns an option

55b2981

The SctkPopup must exist also only once

17bf761

Reason: Otherwise it will not be dropped

store serial only for the press event and not for the release event

471cbd2

Murmele closed this Jun 19, 2026

Murmele reopened this Jun 19, 2026

implement anchoring

0caa552

Murmele force-pushed the popup branch from e31d71a to 4a8ea92 Compare June 24, 2026 10:31

fix clippy and typo

74116c0

Murmele force-pushed the popup branch from 4a8ea92 to 74116c0 Compare June 24, 2026 10:37

ogoffart mentioned this pull request Jun 29, 2026

Native winit popup slint-ui/slint#11740

Draft

3 tasks

Merge branch 'master' into popup

514da9b

make WindowType non_exhaustive

2a3badc

ogoffart reviewed Jul 3, 2026

View reviewed changes

Murmele added 3 commits July 3, 2026 18:10

fix review

d8f74e6

return error if no parent was provided

5e3b9f4

outer_position shall return the position relative to the parent for p…

97a3dfe

…opups

Murmele force-pushed the popup branch from e6a1c63 to 97a3dfe Compare July 7, 2026 07:13

Murmele added 4 commits July 7, 2026 13:18

anchor rect is mandatory

1d517a1

make error! as function

24e788a

return the resulting size from the request_surface_size

c98ad8b

use the seat of the most recent event.

0403286

Otherwise for multiple seats it could happen that we don't grab the keyboard

Uh oh!

Conversation

Murmele commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Platforms

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Murmele commented Jun 18, 2026

Uh oh!

kchibisov commented Jun 18, 2026

Uh oh!

Murmele commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

ogoffart Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Murmele Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ogoffart Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Murmele Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

Murmele Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

ogoffart Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Murmele Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

Murmele commented Mar 25, 2026 •

edited

Loading