Skip to content

chore: prepare v0.1.4 release#121

Open
JamesC1305 wants to merge 1 commit into
rust-vmm:mainfrom
JamesC1305:bump-version-v0.1.4
Open

chore: prepare v0.1.4 release#121
JamesC1305 wants to merge 1 commit into
rust-vmm:mainfrom
JamesC1305:bump-version-v0.1.4

Conversation

@JamesC1305
Copy link
Copy Markdown
Contributor

Prepare a new release, so the new is_allocated method from PR #120 is made available.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

Bump the crate version and add new unreleased section to changelog.

Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Comment thread CHANGELOG.md
Comment on lines 17 to 21
### Changed
### Fixed

- [[#120]](https://github.com/rust-vmm/vm-allocator/pull/120): `IdAllocator::free_id` incorrectly accepted freeing `next_id` (an id that was
never allocated), which could lead to the same id being allocated twice.

### Removed
### Deprecated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a section is empty, can you remove it instead?

Comment thread Cargo.toml
[package]
name = "vm-allocator"
version = "0.1.3"
version = "0.1.4"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a patch release? I was thinking since it's adding support for no-std, it should be a minor instead.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to the maintainers I suppose, happy to bump the minor version instead if you think it warrants that. @ShadowCurse, any thoughts?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep bumping of minor version for breaking changes. (since the crate is still not 1.0)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreeaflorescu if that sounds okay to you, I can just update the changelog (in response to your other comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants