Rollup of 5 pull requests#158638
Closed
jhpratt wants to merge 14 commits into
Closed
Conversation
To emphasize that just because you see a `Scalar(I32)` that doesn't really tell you anything about the alignment it has -- one should be looking at the type (well, the place) for that. No actual layout or behaviour changes in *this* PR.
Co-authored-by: Ralf Jung <post@ralfj.de>
No code changes required, and this cleans up recursive dependencies too.
…without-depth-increase, r=lcnr Do not increase depth when evaluating nested goals of `NormalizesTo` cc rust-lang#156619 (comment) ~~Only the last commit is relevant since this is based on rust-lang#156619~~ r? lcnr
signed strict division: just use normal division For some reason, rust-lang#116090 picked an unnecessarily complicated implementation for this. I don't know if there was any specific reason for this;. Cc @rmehri01 @m-ou-se in case someone remembers. This was pointed out on IRLO: https://internals.rust-lang.org/t/why-is-strict-div-implemented-in-terms-of-overflowing-div-for-signed-integers/24387 Let's just use regular division here, which is consistent with what we do for unsigned types.
…obzol,jieyouxu Deduplicate codegen backends in bootstrap config Deduplicate `rust.codegen-backends` and `target.<triple>.codegen-backends` during bootstrap config parsing while preserving first occurrence order. This avoids carrying redundant backend entries into later bootstrap planning. test: ```powershell $env:CARGO_NET_OFFLINE='false'; $env:CARGO_TARGET_DIR='target-codex-test'; $cargo = Join-Path $env:USERPROFILE '.cargo\bin\cargo.exe'; & $cargo test --manifest-path src/bootstrap/Cargo.toml deduplicates_codegen_backends ``` result: ```text running 1 test test core::config::tests::deduplicates_codegen_backends ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 255 filtered out; finished in 0.00s ```
…ingjubilee Rename `align` to `default_align` on `Scalar` and `Primitive` To emphasize that just because you see a `Scalar(I32)` that doesn't really tell you anything about the alignment it has -- one should be looking at the type (well, the place) for that. (The `size` method doesn't really have that problem -- i32 is always 4 bytes, no matter the context -- so is left untouched.) No actual layout or behaviour changes in *this* PR. Just the rename and some comments. r? @workingjubilee
…huss linkchecker: upgrade to `html5ever v0.39` No code changes required, and this cleans up recursive dependencies too.
rustbot
added
A-LLVM
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors
Bot
removed
the
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
NormalizesTo#157718 (Do not increase depth when evaluating nested goals ofNormalizesTo)aligntodefault_alignonScalarandPrimitive#158542 (Renamealigntodefault_alignonScalarandPrimitive)html5ever v0.39#158636 (linkchecker: upgrade tohtml5ever v0.39)r? @ghost
Create a similar rollup