Skip to content

Remove dependency from rustc_metadata on rustc_incremental#158616

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
blyxyas:less_rustc_incremental_dependents
Jul 1, 2026
Merged

Remove dependency from rustc_metadata on rustc_incremental#158616
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
blyxyas:less_rustc_incremental_dependents

Conversation

@blyxyas

@blyxyas blyxyas commented Jun 30, 2026

Copy link
Copy Markdown
Member

This allows us to depend on rustc_resolve from rustc_incremental. Important for rust-lang/rust-project-goals#641

@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, incremental
  • compiler, incremental expanded to 73 candidates
  • Random selection from 17 candidates

@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@blyxyas
Remove dependency from rustc_codegen_ssa on rustc_incremental
3842da5 
This allows us to depend on `rustc_resolve` from `rustc_incremental`. Important for rust-lang/rust-project-goals#641
@blyxyas blyxyas force-pushed the less_rustc_incremental_dependents branch from 3c1c7bb to 3842da5 Compare June 30, 2026 14:22
@petrochenkov

petrochenkov commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

This looks like a good cleanup in isolation, but this goal

This allows us to depend on rustc_resolve from rustc_incremental

looks quite suspicious.
If some part of rustc_resolve is wanted from rustc_incremental, the it probably shouldn't live in rustc_resolve, please ping me on further changes in this direction.

@rust-bors

rust-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3842da5 has been approved by petrochenkov

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2026
@bjorn3

bjorn3 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Remove dependency from rustc_codegen_ssa on rustc_incremental

You mean from rustc_metadata on rustc_incremental?

@Kobzol

Kobzol commented Jun 30, 2026

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

To see bootstrap timings in isolation (can happen in parallel to merge).

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of #158616 - blyxyas:less_rustc_incremental_dependents, r=…
f6b40a4 
…<try>

Remove dependency from `rustc_codegen_ssa` on `rustc_incremental`
@blyxyas

blyxyas commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

You mean from rustc_metadata on rustc_incremental?

I suppose that should technically be the title, I was thinking about the changes done to rustc_codegen_ssa, althought the dependency is actually removed from rustc_metadata.

@blyxyas blyxyas changed the title Remove dependency from rustc_codegen_ssa on rustc_incremental Remove dependency from rustc_metadata on rustc_incremental Jun 30, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 30, 2026
Merged
@rust-bors

rust-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f6b40a4 (f6b40a4937df5c78e572d44e0a69d699ba168eb3)
Base parent: f46ec52 (f46ec5218fe7829ac18323b5ee0b409a63169f27)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f6b40a4): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.565s -> 484.552s (-0.21%)
Artifact size: 393.29 MiB -> 393.73 MiB (0.11%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of #158629 - JonathanBrouwer:rollup-42QCg7x, r=JonathanBro…
17aa775 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #156379 (lint on `core::ffi::c_void` as a return type)
 - #157347 (Implement `Box::as_non_null()`.)
 - #157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets)
 - #158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items)
 - #158573 (stabilize `feature(atomic_from_mut)`)
 - #158614 (Fix error message when rejecting implicit stage != 2 in CI)
 - #158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
@rust-bors rust-bors Bot merged commit 16cad03 into rust-lang:main Jul 1, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jul 1, 2026
bjorn3 pushed a commit to bjorn3/miri that referenced this pull request Jul 1, 2026
@bors
Auto merge of #158629 - JonathanBrouwer:rollup-42QCg7x, r=JonathanBro…
017151f 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#156379 (lint on `core::ffi::c_void` as a return type)
 - rust-lang/rust#157347 (Implement `Box::as_non_null()`.)
 - rust-lang/rust#157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets)
 - rust-lang/rust#158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items)
 - rust-lang/rust#158573 (stabilize `feature(atomic_from_mut)`)
 - rust-lang/rust#158614 (Fix error message when rejecting implicit stage != 2 in CI)
 - rust-lang/rust#158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

7 participants

@blyxyas @rustbot @rust-log-analyzer @petrochenkov @bjorn3 @Kobzol @rust-timer