Fix error message when rejecting implicit stage != 2 in CI#158614
Merged
rust-bors[bot] merged 1 commit intoJul 1, 2026
Conversation
The previous error message made it sound like stage != 2 was entirely disallowed under CI. But actually it was only *implicit* stage != 2 which is disallowed - an explicit `--stage 1` is permitted and is sometimes correct. Minimal command to trigger the error message: `GITHUB_ACTIONS=true ./x test ui`
Collaborator
|
This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @clubby789 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 30, 2026
…-message, r=clubby789 Fix error message when rejecting implicit stage != 2 in CI The previous error message made it sound like stage != 2 was entirely disallowed under CI. But actually it was only *implicit* stage != 2 which is disallowed - an explicit `--stage 1` is permitted and is sometimes correct. Minimal command to trigger the error message: `GITHUB_ACTIONS=true ./x test ui`
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156379 (lint on `core::ffi::c_void` as a return type) - #157347 (Implement `Box::as_non_null()`.) - #157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets) - #158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items) - #158573 (stabilize `feature(atomic_from_mut)`) - #158614 (Fix error message when rejecting implicit stage != 2 in CI) - #158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2026
Rollup merge of #158614 - fs-rachel:fix-implicit-stage-in-ci-message, r=clubby789 Fix error message when rejecting implicit stage != 2 in CI The previous error message made it sound like stage != 2 was entirely disallowed under CI. But actually it was only *implicit* stage != 2 which is disallowed - an explicit `--stage 1` is permitted and is sometimes correct. Minimal command to trigger the error message: `GITHUB_ACTIONS=true ./x test ui`
bjorn3
pushed a commit
to bjorn3/miri
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#156379 (lint on `core::ffi::c_void` as a return type) - rust-lang/rust#157347 (Implement `Box::as_non_null()`.) - rust-lang/rust#157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets) - rust-lang/rust#158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items) - rust-lang/rust#158573 (stabilize `feature(atomic_from_mut)`) - rust-lang/rust#158614 (Fix error message when rejecting implicit stage != 2 in CI) - rust-lang/rust#158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous error message made it sound like stage != 2 was entirely disallowed under CI. But actually it was only implicit stage != 2 which is disallowed - an explicit
--stage 1is permitted and is sometimes correct.Minimal command to trigger the error message:
GITHUB_ACTIONS=true ./x test ui