Fix getrandom fallback test on platforms with `panic=abort` by fs-rachel · Pull Request #158613 · rust-lang/rust

fs-rachel · 2026-06-30T12:27:27Z

The recently-added linux-getrandom-fallback test fails on targets matching {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*}. This is because those platforms set panic=abort by default, and the test relies on being able to catch a panic.

Mark the test as needs-unwind so that it won't be run in panic=abort configurations.

Also add extra debug information to the panic when getrandom() fails with an unexpected error code on Linux

Fixes test failures on {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*} targets which have panic=abort by default

rustbot · 2026-06-30T12:27:32Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @Darksonn (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 13 candidates
Random selection from 6 candidates

joboet · 2026-06-30T13:33:11Z

Oh, right... thanks!
@bors r+
r? joboet

rust-bors · 2026-06-30T13:33:13Z

📌 Commit 3886e7f has been approved by joboet

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

joboet · 2026-06-30T13:34:48Z

@bors r-
I hadn't realised CI hadn't even started yet... r=me with CI working.

@bors delegate+

rust-bors · 2026-06-30T13:34:53Z

This pull request was unapproved.

View changes since this unapproval

rust-bors · 2026-06-30T13:34:54Z

✌️ @fs-rachel, you can now approve this pull request!

If @joboet told you to "r=me" after making some further change, then please make that change and post @bors r=joboet.

View changes since this delegation.

fs-rachel · 2026-07-01T09:05:57Z

Looks like CI went fine :)

@bors r=joboet

rust-bors · 2026-07-01T09:06:01Z

📌 Commit 3886e7f has been approved by joboet

It is now in the queue for this repository.

…est, r=joboet Fix getrandom fallback test on platforms with `panic=abort` The recently-added linux-getrandom-fallback test fails on targets matching {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*}. This is because those platforms set `panic=abort` by default, and the test relies on being able to catch a panic. Mark the test as `needs-unwind` so that it won't be run in `panic=abort` configurations. Also add extra debug information to the panic when getrandom() fails with an unexpected error code on Linux

…uwer Rollup of 5 pull requests Successful merges: - #158169 (Fix debuginfo compression in bootstrap) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.)

…est, r=joboet Fix getrandom fallback test on platforms with `panic=abort` The recently-added linux-getrandom-fallback test fails on targets matching {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*}. This is because those platforms set `panic=abort` by default, and the test relies on being able to catch a panic. Mark the test as `needs-unwind` so that it won't be run in `panic=abort` configurations. Also add extra debug information to the panic when getrandom() fails with an unexpected error code on Linux

…uwer Rollup of 8 pull requests Successful merges: - #150075 (Implement clamp_to) - #158169 (Fix debuginfo compression in bootstrap) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)

…est, r=joboet Fix getrandom fallback test on platforms with `panic=abort` The recently-added linux-getrandom-fallback test fails on targets matching {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*}. This is because those platforms set `panic=abort` by default, and the test relies on being able to catch a panic. Mark the test as `needs-unwind` so that it won't be run in `panic=abort` configurations. Also add extra debug information to the panic when getrandom() fails with an unexpected error code on Linux

…uwer Rollup of 8 pull requests Successful merges: - #150075 (Implement clamp_to) - #156716 (tests: fix: parallel frontend test failures: different alloc ids) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)

…uwer Rollup of 8 pull requests Successful merges: - #158294 (Use .drectve for MSVC DLL exports) - #156716 (tests: fix: parallel frontend test failures: different alloc ids) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)

Rollup merge of #158613 - fs-rachel:fix-getrandom-fallback-test, r=joboet Fix getrandom fallback test on platforms with `panic=abort` The recently-added linux-getrandom-fallback test fails on targets matching {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*}. This is because those platforms set `panic=abort` by default, and the test relies on being able to catch a panic. Mark the test as `needs-unwind` so that it won't be run in `panic=abort` configurations. Also add extra debug information to the panic when getrandom() fails with an unexpected error code on Linux

jyn514 and others added 2 commits June 30, 2026 13:20

give a better error when getrandom fails

d3e3e67

Mark linux-getrandom-fallback test as needs-unwind

3886e7f

Fixes test failures on {aarch64*-none, armv7r-eabihf, thumbv7em-eabi*} targets which have panic=abort by default

rustbot assigned Darksonn Jun 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 30, 2026

rustbot assigned joboet Jun 30, 2026

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 30, 2026

rustbot unassigned Darksonn Jun 30, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 30, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 30, 2026

fs-rachel mentioned this pull request Jun 30, 2026

Automated pull from upstream HEAD ferrocene/ferrocene#2412

Merged

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2026

JonathanBrouwer mentioned this pull request Jul 1, 2026

Rollup of 5 pull requests #158650

Closed

JonathanBrouwer mentioned this pull request Jul 1, 2026

Rollup of 8 pull requests #158660

Closed

JonathanBrouwer mentioned this pull request Jul 1, 2026

Rollup of 8 pull requests #158661

Closed

JonathanBrouwer mentioned this pull request Jul 1, 2026

Rollup of 8 pull requests #158663

Merged

rust-bors Bot merged commit 1f10847 into rust-lang:main Jul 1, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jul 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix getrandom fallback test on platforms with `panic=abort`#158613

Fix getrandom fallback test on platforms with `panic=abort`#158613
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
fs-rachel:fix-getrandom-fallback-test

fs-rachel commented Jun 30, 2026

Uh oh!

rustbot commented Jun 30, 2026

Uh oh!

joboet commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

joboet commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

fs-rachel commented Jul 1, 2026

Uh oh!

rust-bors Bot commented Jul 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

fs-rachel commented Jun 30, 2026

Uh oh!

rustbot commented Jun 30, 2026

Uh oh!

joboet commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

joboet commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

rust-bors Bot commented Jun 30, 2026

Uh oh!

fs-rachel commented Jul 1, 2026

Uh oh!

rust-bors Bot commented Jul 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants