Test(lib/net): Fix hostname_smoketest for Win7#158563
Merged
rust-bors[bot] merged 1 commit intoJun 30, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
PaulDance
force-pushed
the
patches/fix-win7-hostname_smoketest
branch
from
724b396 to
0ecefc5
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
JohnTitor
approved these changes
Jun 29, 2026
Member
There was a problem hiding this comment.
Could you fix this warning? #158563 (comment)
Otherwise LGTM.
This test currently fails under both x86 and x86_64 Win7 on:
```
thread 'net::tests::hostname_smoketest' (2304) panicked at library/std/src/net/tests.rs:46:14:
called `Result::unwrap()` on an `Err` value: Error { kind: Unsupported, message: "operation not supported on this platform" }
```
This is simply because the feature was made to be effectively disabled
under these targets in PR 150905. The test is therefore fixed in order
to reflect that appropriately.
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
PaulDance
force-pushed
the
patches/fix-win7-hostname_smoketest
branch
from
0ecefc5 to
3ace8f4
Compare
Contributor
Author
|
Ah yes, sorry. Fixed. |
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-timer
added a commit
that referenced
this pull request
Jun 30, 2026
Rollup merge of #158563 - PaulDance:patches/fix-win7-hostname_smoketest, r=JohnTitor Test(lib/net): Fix `hostname_smoketest` for Win7 This test currently fails under both x86 and x86_64 Win7 on: ``` thread 'net::tests::hostname_smoketest' (2304) panicked at library/std/src/net/tests.rs:46:14: called `Result::unwrap()` on an `Err` value: Error { kind: Unsupported, message: "operation not supported on this platform" } ``` This is simply because the feature was made to be effectively disabled under these targets in #150905. The test is therefore fixed in order to reflect that appropriately. cc #135142 @roblabla @rustbot label O-windows-7 O-x86_32 O-x86_64 A-io T-libs
Contributor
Author
|
🙏 |
bjorn3
pushed a commit
to bjorn3/miri
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - rust-lang/rust#158560 (Move per-function debuginfo methods from codegen to builder methods) - rust-lang/rust#158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - rust-lang/rust#158571 (Update books) - rust-lang/rust#158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test currently fails under both x86 and x86_64 Win7 on:
This is simply because the feature was made to be effectively disabled under these targets in #150905. The test is therefore fixed in order to reflect that appropriately.
cc #135142 @roblabla
@rustbot label O-windows-7 O-x86_32 O-x86_64 A-io T-libs