Skip to content

Rollup of 9 pull requests#158228

Merged
rust-bors[bot] merged 45 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-AUgEk0s
Jun 22, 2026
Merged

Rollup of 9 pull requests#158228
rust-bors[bot] merged 45 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-AUgEk0s

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

bjorn3 and others added 30 commits June 10, 2026 16:45
This will make it easier to change how proc-macros are implemented on
the rustc side. For example allowing support for wasm proc-macros
without duplicating the implementation between proc-macro-srv and rustc.
This updates the rust-version file to 4e391cf.
This updates the rust-version file to 3daae5e.
[Priroda] Add `stepi` and `locals` commands, and handle repeated breakpoint hits on the same source line
This updates the rust-version file to c55fad5.
ipc-channel 0.21 switched serialization from bincode to postcard,
removing the transitive dependency on the unmaintained bincode 1.x
(RUSTSEC-2025-0141). All APIs Miri uses remain unchanged.
ipc-channel 0.22 re-exports `TryRecvError` at the crate root instead
of the `ipc` module, where it is now a private import.
Update ipc-channel to 0.22 to drop bincode dependency
This updates the rust-version file to 01f54e8.
…, r=Mark-Simulacrum

Update backtrace submodule to pick up AIX related fixes.

This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
Use the target checking infrastructure for the diagnostic attributes

The goal of this is a few things:
* Make the diagnostic attributes' target checking cleaner and more declarative, making it harder to make mistakes here
* Make progress towards removing the `ALL_TARGETS` list

r? @mejrs
…Simulacrum

Add me to some rotation groups

Add me to some groups that I've involved with.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 21, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Jun 21, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4849b10 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

--- BACKTRACE vvv
   0: <bootstrap::utils::exec::DeferredCommand>::finish_process
             at /checkout/src/bootstrap/src/utils/exec.rs:939:17
   1: <bootstrap::utils::exec::DeferredCommand>::wait_for_output::<&bootstrap::utils::exec::ExecutionContext>
             at /checkout/src/bootstrap/src/utils/exec.rs:831:21
   2: <bootstrap::utils::exec::ExecutionContext>::run
             at /checkout/src/bootstrap/src/utils/exec.rs:741:45
   3: <bootstrap::utils::exec::BootstrapCommand>::run::<&bootstrap::core::builder::Builder>
             at /checkout/src/bootstrap/src/utils/exec.rs:339:27
   4: bootstrap::core::build_steps::toolstate::checkout_toolstate_repo
             at /checkout/src/bootstrap/src/core/build_steps/toolstate.rs:319:10
   5: <bootstrap::core::build_steps::toolstate::ToolStateCheck as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/toolstate.rs:177:9
   6: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::toolstate::ToolStateCheck>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1597:36
   7: <bootstrap::core::build_steps::toolstate::ToolStateCheck as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/toolstate.rs:230:21
   8: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
   9: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:232:18
  10: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1140:9
  11: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1119:14
  12: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:803:25
  13: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:130:11
  14: <fn() as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
  15: std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/sys/backtrace.rs:166:18
  16: std::rt::lang_start::<()>::{closure#0}
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/rt.rs:206:18
  17: <&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:287:21
  18: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:581:40
  19: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:544:19
  20: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panic.rs:359:14
  21: std::rt::lang_start_internal::{closure#0}
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/rt.rs:175:24
  22: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:581:40
---
  29: __libc_start_main
  30: _start


Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:14
  local time: Sun Jun 21 21:57:47 UTC 2026
  network time: Sun, 21 Jun 2026 21:57:48 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2026
@rust-bors

rust-bors Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 28m 2s
Pushing e238223 to main...

@rust-bors rust-bors Bot merged commit e238223 into rust-lang:main Jun 22, 2026
7 of 14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 22, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#156356 bootstrap: add bootstrap step to run intrinsic-test in CI 023823f2a92215a5de508aac4685747da7a5773a (link)
#157711 Move proc-macro dlopen from proc-macro-srv to rustc_metadata 1dda445326036bc045a8b70b1a8c234abf5bbff6 (link)
#157836 rebuild LLVM when bootstrap.toml config changes 26cf92e4edd4c9096405de2e505fa5a74edf0b5c (link)
#158108 Update actions/download-artifact action to v8.0.1 f5f2eaad4da8097ee0b6409b5a40981ba0b4f6fe (link)
#158150 Update backtrace submodule to pick up AIX related fixes. 486253948757ff1f96599cbfadb1f5e45058ab89 (link)
#158178 Use the target checking infrastructure for the diagnostic a… de4be36e52f23b1651d37ae1f62a539148d87095 (link)
#158195 Add me to some rotation groups 43a3aaaa1c6e08f54c62df60894dcc8953694073 (link)
#158214 Don't try to remove assignments in SimplifyComparisonIntegr… 6fd92a3efedde1ce4abf9f9aa076b299f58848a8 (link)
#158226 miri subtree update cf5dbc021d2a36cb11d29628e7e058137c9f25d7 (link)

previous master: 91fe22da80

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 91fe22d (parent) -> e238223 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e238223b17937be1d3682b7f28eb91945f372ae8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 6m 54s -> 14m 6s (+104.3%)
  2. x86_64-msvc-ext3: 1h 3m -> 1h 51m (+74.9%)
  3. x86_64-gnu: 1h 45m -> 2h 27m (+39.8%)
  4. dist-aarch64-linux: 1h 44m -> 2h 18m (+31.7%)
  5. dist-x86_64-msvc-alt: 2h 44m -> 2h 1m (-26.4%)
  6. i686-gnu-2: 1h 22m -> 1h 41m (+22.8%)
  7. x86_64-gnu-debug: 1h 43m -> 2h 6m (+22.6%)
  8. dist-i686-mingw: 2h 38m -> 2h 4m (-21.7%)
  9. dist-apple-various: 1h 44m -> 2h 5m (+20.1%)
  10. x86_64-rust-for-linux: 43m 44s -> 52m 7s (+19.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e238223): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 2

Max RSS (memory usage)

Results (primary 3.6%, secondary 5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.6% [0.5%, 12.5%] 177
Regressions ❌
(secondary)
5.2% [0.8%, 11.5%] 277
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.6% [0.5%, 12.5%] 177

Cycles

Results (primary 4.5%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.5% [1.8%, 8.7%] 63
Regressions ❌
(secondary)
4.9% [1.9%, 9.1%] 47
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-6.7%, -2.0%] 4
All ❌✅ (primary) 4.5% [1.8%, 8.7%] 63

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 480.522s -> 505.375s (5.17%)
Artifact size: 391.37 MiB -> 352.99 MiB (-9.81%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.