Rollup of 3 pull requests#158159
Conversation
fix: clarify that fs::rename on unix accepts targets that don't exist
Expand diagnostic for attributes on macro calls As far as I am aware there are no attributes that do something when used on macro invocations. r? @JonathanBrouwer
…jhpratt add a test for the `getrandom` fallback Now that the randomness API is nearing stabilisation, I think it'd be quite good to have a test for our `getrandom` fallback code to rule out any issues with the polling logic. This test uses symbol interposition to control the `getrandom` return value; I tried to make it as resilient to changes to the `SystemRng`-internals as possible.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: f428d123ab In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing f428d12 (parent) -> 32ea361 (this PR) Test differencesShow 74 test diffsStage 1
Stage 2
Additionally, 70 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 32ea3615cc027bcb8fd720c7511ffb484f6223a3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (32ea361): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 5.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.7%, secondary -4.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 482.643s -> 489.308s (1.38%) |
Successful merges:
getrandomfallback #158125 (add a test for thegetrandomfallback)r? @ghost
Create a similar rollup