Skip to content

Move rustdoc run-make tests into new tests/run-make/rustdoc/#157860

Open
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:mkdir-tests-run-make-rustdoc
Open

Move rustdoc run-make tests into new tests/run-make/rustdoc/#157860
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:mkdir-tests-run-make-rustdoc

Conversation

@fmease

@fmease fmease commented Jun 13, 2026

Copy link
Copy Markdown
Member

Furthermore, populate tests/run-make/rustdoc/doctest/ with doctest run-make tests and tests/run-make/rustdoc/scrape-example/ with scrape-example run-make tests.

For context we currently have 11 doctest run-make tests + 8 scrape-example run-make tests + 24 other rustdoc run-make tests = 43 rustdoc run-make tests in total.

Motivation: Sorta obvious but

  1. I want to be able to just call e.g., ./x t tests/run-make/rustdoc/doctest tests/rustdoc-ui/doctest when working on doctest internals to quickly see if anything broke instead of having to execute all run-make tests "every time I make a small change"
  2. having them in one official place makes it a lot easier to spot which areas might need more coverage, to take inspiration from existing rustdoc run-make tests, to find existing test files that one can extend instead of creating a whole new run-make test, etc.

r? rustdoc

Furthermore, populate `tests/run-make/rustdoc/doctest/` with doctest
run-make tests and `tests/run-make/rustdoc/scrape-example/` with scrape
example run-make tests.
@rustbot

rustbot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2026
@rust-bors

rust-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #158593) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants