Skip to content

stabilize never type#155499

Open
WaffleLapkin wants to merge 13 commits into
rust-lang:mainfrom
WaffleLapkin:stabilize-never-type
Open

stabilize never type#155499
WaffleLapkin wants to merge 13 commits into
rust-lang:mainfrom
WaffleLapkin:stabilize-never-type

Conversation

@WaffleLapkin

@WaffleLapkin WaffleLapkin commented Apr 18, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

This PR:

Cat:
52270233795_5979a3174d_b

Tracking:

Stabilization plan FCP:

Lint bump:

Rust 2024 edition change:

@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 18, 2026
@rustbot

rustbot commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

@WaffleLapkin WaffleLapkin marked this pull request as draft April 18, 2026 22:14
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
@WaffleLapkin

WaffleLapkin commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 18, 2026
@bors
Auto merge of #155499 - WaffleLapkin:stabilize-never-type, r=<try>
1c4199d 
[experiment][0] nya
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1c4199d (1c4199da70f816f2239f41c55168ff75a3663718, parent: b2f1ccf524a3a4cf9c34545167cc23b659cf1cbd)

@WaffleLapkin WaffleLapkin force-pushed the stabilize-never-type branch from 2895d33 to 3e8df8d Compare April 19, 2026 01:05
@WaffleLapkin

WaffleLapkin commented Apr 19, 2026

Copy link
Copy Markdown
Member Author

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-154887/retry-regressed-list.txt

@craterbot

craterbot commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-155499 created and queued.
🤖 Automatically detected try build 1c4199d
⚠️ Try build based on commit 2895d33, but latest commit is 3e8df8d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2026
@craterbot

craterbot commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-155499 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-155499 is completed!
📊 3277 regressed and 0 fixed (9024 total)
📊 1149 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-155499/retry-regressed-list.txt ↩

@WaffleLapkin WaffleLapkin force-pushed the stabilize-never-type branch from 5675e12 to 8b0d675 Compare June 16, 2026 20:20
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the stabilize-never-type branch from 8b0d675 to 4967024 Compare June 17, 2026 10:07
jplatte
jplatte reviewed Jun 17, 2026
View reviewed changes
Comment thread compiler/rustc_ast_ir/src/lib.rs
@rust-bors

This comment has been minimized.

Sign in to view
@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 21, 2026
@rust-rfcbot

rust-rfcbot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

@rustbot rustbot mentioned this pull request Jun 21, 2026
Open
@WaffleLapkin
Set never type fallback to always be !
ccf17b2
@WaffleLapkin
stabilize the never type (!)
25d7ad2
@WaffleLapkin
fixup clippy::empty_enums
af6419e
@WaffleLapkin
remove #![feature(never_type)] from the compiler
3df1344 
The reason `rustc_ast_ir` and `rustc_pattern_analysis` have nested
`cfg_attr`s is so that they don't mention `cfg(bootstrap)` when nightly
or rustc cargo feature turned on. If you don't do it like that, they stop
compiling on stable (or rather, they emit unexpected cfg warnings...).
@WaffleLapkin
remove #![feature(never_type)] from tests
c761e07
@WaffleLapkin
remove #![feature(never_type)] from library
2d62a24
@WaffleLapkin
remove #![feature(never_type)] from tools
064e664
@WaffleLapkin
bless tests
7d9d7b1
@WaffleLapkin
bless mir-opt tests
e6f69a4
@WaffleLapkin
update tests which depended on never fallback to ()
bbf4786
@WaffleLapkin
remove dependency_on_unit_never_type_fallback lint
259e618
@WaffleLapkin
remove stray stderr files
ff18220 
??? why wasn't this detected by compiletest ???
@WaffleLapkin
update edition-guide submodule to unfuck tests there
d9b4a18
@WaffleLapkin WaffleLapkin force-pushed the stabilize-never-type branch from 4967024 to d9b4a18 Compare June 24, 2026 18:13
@rustbot

rustbot commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@WaffleLapkin WaffleLapkin mentioned this pull request Jun 24, 2026
Draft
@tmandry tmandry self-assigned this Jun 24, 2026
@rust-bors

rust-bors Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #156742) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

@lcnr

lcnr commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@WaffleLapkin and @JonathanBrouwer are still actively working on some of the compatibility changes for this stabilization

Merging this PR is waiting on that work being done from what I can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments
@theemathas theemathas theemathas left review comments
@Nadrieril Nadrieril Nadrieril left review comments
+1 more reviewer
@jplatte jplatte jplatte left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@tmandry tmandry

@jackh726 jackh726

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. needs-reference-pr This language change needs an approved Reference PR to proceed. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.