HirIdify some lints#3814
Conversation
|
Ah, I forgot this will already break on new rustc stuff; in any case, please advise which commit I should attach this PR to (unless this one's fine). |
Done! |
|
There was a bug; I went through all the changes and found it (mixed the ids in one spot), but unfortunately I'm unable to run tests at this moment 😐; hope it's the only one. Can we please branch the new commit so I can retry with rust-lang's CI? |
|
done |
|
Yep, that was the only one; thanks! |
|
rust-lang/rust#58561 was merged, feel free to merge this branch now. |
|
You're fast! Retriggering CI =) |
|
I'm guessing the branch build doesn't have the most recent rust-lang commits? |
Nope, just some formatting to be done: https://travis-ci.com/rust-lang/rust-clippy/jobs/180536937#L1395 |
|
Ah, I was looking at appveyor that was showing old errors; I'll send a fix shortly. |
|
@bors r+ thanks! |
|
📌 Commit c1b65ec has been approved by |
HirIdify some lints Unblocks rust-lang/rust#58561 (a part of [rust-lang/rust#57578](rust-lang/rust#57578)). Can we branch it like with #3790? I can rebase on a different commit if need be. Haven't had time to run tests yet, so I'd wait for Travis 🙈.
|
☀️ Test successful - checks-travis, status-appveyor |
5 participants
Unblocks rust-lang/rust#58561 (a part of rust-lang/rust#57578). Can we branch it like with #3790? I can rebase on a different commit if need be.
Haven't had time to run tests yet, so I'd wait for Travis 🙈.