Skip to content

refactor: deprecate *NUM constants fitting #3131#5123

Open
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:_num-deprecation
Open

refactor: deprecate *NUM constants fitting #3131#5123
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:_num-deprecation

Conversation

@dybucc

@dybucc dybucc commented May 30, 2026

Copy link
Copy Markdown
Contributor

Description

Constants matching the *NUM naming scheme whose purpose is that of denoting a limit among other symbols have been deprecated in this patch. This stems from the deprecation efforts in #3131.

This is a follow up PR to #5120.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@dybucc dybucc changed the title refactor: deprecate constants matching _NUM refactor: deprecate *NUM constants fitting #3131 May 30, 2026
@dybucc dybucc force-pushed the _num-deprecation branch 2 times, most recently from 44189c0 to f722733 Compare June 4, 2026 07:09
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@dybucc

dybucc commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

CI actually passes. There seems to be an issue with a glob import that is not used, but this has not
been changed in the patch (it's not even part of it, for that matter.) For some reason, rebasing
onto main with dependabot updates has ended up with a warning across all of my open PRs due to
that one (now apparently unused) import.

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 9, 2026
@dybucc dybucc force-pushed the _num-deprecation branch from fdca478 to e29aff9 Compare June 15, 2026 15:18
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@tgross35

Copy link
Copy Markdown
Contributor

Needs the same doc comment updates
@rustbot author

@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Some symbols are not stable. New upstream releases may change them. This
works out badly with SemVer. Advising users is necessary.
@dybucc dybucc force-pushed the _num-deprecation branch from 7c45459 to ab979ef Compare June 22, 2026 17:18
@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@dybucc

dybucc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@tgross35 The documentation link is wrong. There was an analogous PR with the same link. That was not caught then. What should the link be?

@rustbot ready review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants